[Sonic-DASH] Dash Tunnel and FNIC changes by prsunny · Pull Request #1911 · sonic-net/SONiC

prsunny · 2025-02-06T01:42:11Z

Updated to rev 2.4 for:

Dash Tunnel behavior
PA validation updates
Switch attributes

mssonicbld · 2025-02-06T01:42:14Z

/azp run

azure-pipelines · 2025-02-06T01:42:20Z

No pipelines are associated with this pull request.

prsunny · 2025-02-06T01:44:50Z

@theasianpianist , @mukeshmv , @prabhataravind , @kperumalbfn , @r12f, @oleksandrivantsiv, @marian-pritsak for viz

prsunny · 2025-02-06T01:59:33Z

@KrisNey-MSFT

mssonicbld · 2025-02-06T02:47:19Z

/azp run

azure-pipelines · 2025-02-06T02:47:25Z

No pipelines are associated with this pull request.

mukeshmv · 2025-02-06T22:16:25Z

doc/dash/dash-sonic-hld.md

 endpoints                = list of addresses for ecmp tunnel
 encap_type               = vxlan or nvgre
-vni                      = vni value for encap
+vni                      = vni value for encap, create only attribute


should we mention create only attribute for encap_type as well ?

mukeshmv · 2025-02-06T22:20:28Z

doc/dash/dash-sonic-hld.md

+
+For single endpoint, implmentation shall simply create a sai_dash_tunnel object with ```SAI_DASH_TUNNEL_ATTR_DIP=endpoint IP``` and ```SAI_DASH_TUNNEL_ATTR_MAX_MEMBER_SIZE=1```
+
+For ECMP, implementation shall create ```sai_dash_tunnel_member``` and ```sai_dash_tunnel_next_hop``` with appropriate ```SAI_DASH_TUNNEL_ATTR_MAX_MEMBER_SIZE```


Please mention that though members can be updated, at any point the number of members cannot exceed the count provided at Dash tunnel create

mukeshmv · 2025-02-06T22:25:48Z

doc/dash/dash-sonic-hld.md

    - Telemetry and Monitoring
    - Private Link
    - Private Link NSG
+    - Express Route GW Bypass


can we have a config example for express route gw bypass ?

Will add as a next iteration (another PR)

added an example

mssonicbld · 2025-02-07T00:31:36Z

/azp run

azure-pipelines · 2025-02-07T00:31:42Z

No pipelines are associated with this pull request.

mukeshmv · 2025-02-07T06:33:05Z

doc/dash/dash-sonic-hld.md

        "addresses": {{list of addresses}} 
        "encap_type": {{encap type}}
        "vni": {{vni}}
+        "region_id": {{local region id}}


Region ID is already added to the APPLIANCE table. This is the wrong deprecated Routing Appliance table

Yes. Prince, the routing appliance table is not the appliance table.

Thanks for catching. addressed

mukeshmv · 2025-02-07T06:35:47Z

doc/dash/dash-sonic-hld.md

    "sip": {{ip_address}}
    "vm_vni": {{vni}}
    "local_region_id": {{region_id}}
+    "outbound_direction_lookup": {{dst_mac/src_mac}}


do we still need this attribute if we have Floating NIC mode ?

Yes, if there is fnic mode disabled and need to change the lookup attribute. Basically, aligning with SAI model

mukeshmv

couple more comments

doc/dash/dash-sonic-hld.md

r12f · 2025-02-07T17:20:05Z

doc/dash/dash-sonic-hld.md

        "addresses": {{list of addresses}} 
        "encap_type": {{encap type}}
        "vni": {{vni}}
+        "region_id": {{local region id}}


Yes. Prince, the routing appliance table is not the appliance table.

r12f · 2025-02-07T17:22:09Z

doc/dash/dash-sonic-hld.md

    "sip": {{ip_address}}
    "vm_vni": {{vni}}
    "local_region_id": {{region_id}}
+    "outbound_direction_lookup": {{dst_mac/src_mac}}


Do we have a vni table? The will be multiple VNIs needing this.

We don't have a VNI table currently.

r12f · 2025-02-07T17:24:33Z

doc/dash/dash-sonic-hld.md

+DASH_PA_VALIDATION_TABLE is used only for additional PA validation. PA prefix can be either IPV4 or IPV6. Used for fastpath or other explicit PA validation cases

-For more scale numbers, please refer to the [doc](https://github.com/sonic-net/DASH/blob/main/documentation/express-route-service/express-route-gateway-bypass.md)
+Expected max number of 4K PA_VALIDATION entries. For more scale numbers, please refer to the [doc](https://github.com/sonic-net/DASH/blob/main/documentation/express-route-service/express-route-gateway-bypass.md)


Maybe better to mention this in scaling requirements too, if missed.

Or simply move to there, in case inconsistent in future.

added to scale section and removed from here

mssonicbld · 2025-02-10T19:06:13Z

/azp run

azure-pipelines · 2025-02-10T19:06:20Z

No pipelines are associated with this pull request.

oleksandrivantsiv · 2025-02-11T21:14:36Z

doc/dash/dash-sonic-hld.md

 endpoints                = list of addresses for ecmp tunnel
-encap_type               = vxlan or nvgre
-vni                      = vni value for encap
+encap_type               = vxlan or nvgre, create only attribute


For the encap_type can we add an explicit definishion of what is expected return packet?

added a statement

mssonicbld · 2025-02-12T01:20:12Z

/azp run

azure-pipelines · 2025-02-12T01:20:18Z

No pipelines are associated with this pull request.

prsunny · 2025-02-12T04:11:22Z

@mzms, please review the expected dash config section for er gw

prabhataravind

lgtm

mzms · 2025-03-12T01:26:14Z

looks good

* If no value is specified, use a default value of SAI_DASH_ENI_MAC_OVERRIDE_TYPE_SRC_MAC, else use the specified value. Ref: sonic-net/SONiC#1911 Signed-off-by: Prabhat Aravind <[email protected]>

* Handle outbound_direction_lookup for DASH_APPLIANCE_TABLE * If no value is specified, use a default value of SAI_DASH_ENI_MAC_OVERRIDE_TYPE_SRC_MAC, else use the specified value. Ref: sonic-net/SONiC#1911

…3571) * Handle outbound_direction_lookup for DASH_APPLIANCE_TABLE * If no value is specified, use a default value of SAI_DASH_ENI_MAC_OVERRIDE_TYPE_SRC_MAC, else use the specified value. Ref: sonic-net/SONiC#1911

Referring to sonic-net/SONiC#1911 and #665, to support FNIC pipeline, this PR adds the followings: - ENI mode VM, FNIC - ENI drop counter `eni_trusted_vni_entry_miss_drop` - Action `set_inbound_direction` is not defaultonly at table `direction_lookup` - table `global_trusted_vni` and `eni_trusted_vni` --------- Signed-off-by: Junhua Zhai <[email protected]>

As per sonic-net/SONiC#1911 --------- Signed-off-by: Lawrence Lee <[email protected]>

* Dash tunnel and FNIC changes * Updated to rev 2.4 for: Dash Tunnel behavior PA validation updates Switch attributes

*[DASH] Support trusted VNIs for appliance and ENI objects (#3728) What I did Program trusted VNI info to SAI layer for appliance and ENI objects when available Why I did it As per sonic-net/SONiC#1911

**What I did** - Program trusted VNI info to SAI layer for appliance and ENI objects when available **Why I did it** As per sonic-net/SONiC#1911 **How I verified it** Run the unit tests **Details if related**

…3728) *[DASH] Support trusted VNIs for appliance and ENI objects (sonic-net#3728) What I did Program trusted VNI info to SAI layer for appliance and ENI objects when available Why I did it As per sonic-net/SONiC#1911

…3571) * Handle outbound_direction_lookup for DASH_APPLIANCE_TABLE * If no value is specified, use a default value of SAI_DASH_ENI_MAC_OVERRIDE_TYPE_SRC_MAC, else use the specified value. Ref: sonic-net/SONiC#1911

…3728) *[DASH] Support trusted VNIs for appliance and ENI objects (sonic-net#3728) What I did Program trusted VNI info to SAI layer for appliance and ENI objects when available Why I did it As per sonic-net/SONiC#1911

…3728) *[DASH] Support trusted VNIs for appliance and ENI objects (sonic-net#3728) What I did Program trusted VNI info to SAI layer for appliance and ENI objects when available Why I did it As per sonic-net/SONiC#1911 Signed-off-by: Lawrence Lee <[email protected]>

…3571) * Handle outbound_direction_lookup for DASH_APPLIANCE_TABLE * If no value is specified, use a default value of SAI_DASH_ENI_MAC_OVERRIDE_TYPE_SRC_MAC, else use the specified value. Ref: sonic-net/SONiC#1911 Signed-off-by: Baorong Liu <[email protected]>

…3728) *[DASH] Support trusted VNIs for appliance and ENI objects (sonic-net#3728) What I did Program trusted VNI info to SAI layer for appliance and ENI objects when available Why I did it As per sonic-net/SONiC#1911 Signed-off-by: Baorong Liu <[email protected]>

prsunny added 2 commits February 5, 2025 16:35

Dash tunnel and FNIC changes

4900026

Dash tunnel and FNIC changes (#1910)

7acceee

Override mac

de5b63e

r12f self-requested a review February 6, 2025 04:34

mukeshmv reviewed Feb 6, 2025

View reviewed changes

Updated for create only

d6c72be

mukeshmv approved these changes Feb 7, 2025

View reviewed changes

mukeshmv reviewed Feb 7, 2025

View reviewed changes

r12f reviewed Feb 7, 2025

View reviewed changes

Address review comments

16da30a

oleksandrivantsiv reviewed Feb 11, 2025

View reviewed changes

Added and example for ER GW

51c5ba5

prsunny requested a review from mukeshmv February 12, 2025 03:17

prabhataravind approved these changes Mar 11, 2025

View reviewed changes

mukeshmv approved these changes Mar 11, 2025

View reviewed changes

r12f approved these changes Mar 11, 2025

View reviewed changes

prsunny merged commit 6f524f2 into master Mar 11, 2025
1 check passed

theasianpianist mentioned this pull request Mar 13, 2025

Add tunnel field to route message sonic-net/sonic-dash-api#34

Merged

This was referenced Mar 26, 2025

Handle outbound_direction_lookup for DASH_APPLIANCE_TABLE sonic-net/sonic-swss#3571

Merged

Make outbound_direction_lookup optional sonic-net/sonic-dash-api#36

Merged

jimmyzhai mentioned this pull request Apr 9, 2025

[dash-p4] Add ENI mode and trusted vni stage sonic-net/DASH#672

Merged

theasianpianist mentioned this pull request Apr 18, 2025

Add attributes for FNIC sonic-net/sonic-dash-api#37

Merged

theasianpianist added a commit to sonic-net/sonic-dash-api that referenced this pull request Apr 18, 2025

Add attributes for FNIC (#37)

817c0f4

As per sonic-net/SONiC#1911 --------- Signed-off-by: Lawrence Lee <[email protected]>

theasianpianist mentioned this pull request Jun 25, 2025

[DASH] Support trusted VNIs for appliance and ENI objects sonic-net/sonic-swss#3728

Merged

vkjammala-arista pushed a commit to vkjammala-arista/SONiC that referenced this pull request Jul 9, 2025

[Sonic-DASH] Dash Tunnel and FNIC changes (sonic-net#1911)

08eac07

* Dash tunnel and FNIC changes * Updated to rev 2.4 for: Dash Tunnel behavior PA validation updates Switch attributes

mssonicbld mentioned this pull request Jul 16, 2025

[action] [PR:3728] [DASH] Support trusted VNIs for appliance and ENI objects Azure/sonic-swss.msft#107

Merged


		For single endpoint, implmentation shall simply create a sai_dash_tunnel object with ```SAI_DASH_TUNNEL_ATTR_DIP=endpoint IP``` and ```SAI_DASH_TUNNEL_ATTR_MAX_MEMBER_SIZE=1```

		For ECMP, implementation shall create ```sai_dash_tunnel_member``` and ```sai_dash_tunnel_next_hop``` with appropriate ```SAI_DASH_TUNNEL_ATTR_MAX_MEMBER_SIZE```

Conversation

prsunny commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Feb 6, 2025

Uh oh!

azure-pipelines bot commented Feb 6, 2025

Uh oh!

prsunny commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prsunny commented Feb 6, 2025

Uh oh!

mssonicbld commented Feb 6, 2025

Uh oh!

azure-pipelines bot commented Feb 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Feb 7, 2025

Uh oh!

azure-pipelines bot commented Feb 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mukeshmv Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mukeshmv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Feb 10, 2025

Uh oh!

azure-pipelines bot commented Feb 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Feb 12, 2025

Uh oh!

azure-pipelines bot commented Feb 12, 2025

Uh oh!

prsunny commented Feb 12, 2025

Uh oh!

prabhataravind left a comment

Choose a reason for hiding this comment

Uh oh!

prsunny commented Feb 6, 2025 •

edited

Loading

prsunny commented Feb 6, 2025 •

edited

Loading

mukeshmv Feb 7, 2025 •

edited

Loading