[DASH] Support trusted VNIs for appliance and ENI objects#3728
Merged
prsunny merged 18 commits intosonic-net:masterfrom Jul 11, 2025
Merged
[DASH] Support trusted VNIs for appliance and ENI objects#3728prsunny merged 18 commits intosonic-net:masterfrom
prsunny merged 18 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for trusted VNI programming across appliance and ENI objects by extending the SAI layer mocking and orchestration code. Key changes include:
- Adding new SAI API calls and mocks for trusted VNIs.
- Updating unit tests and orchagent functions to create and remove trusted VNI entries.
- Extending protobuf utilities to convert trusted VNI values.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/mock_tests/ut_saihelper.cpp | Adds SAI API query for trusted VNI. |
| tests/mock_tests/mock_sai_api.h | Introduces new macros for entry API mocks for trusted VNI. |
| tests/mock_tests/mock_orchagent_main.h | Declares the trusted VNI API pointer. |
| tests/mock_tests/mock_dash_orch_test.* | Updates test helpers and adds tests for trusted VNI usage. |
| orchagent/saihelper.cpp | Declares the trusted VNI API pointer. |
| orchagent/dash/pbutils.{h,cpp} | Adds conversion function for trusted VNI ValueOrRange. |
| orchagent/dash/dashorch.{h,cpp} | Implements creation and removal of trusted VNI entries. |
Comments suppressed due to low confidence (1)
orchagent/dash/pbutils.cpp:105
- The new conversion function 'to_sai(const dash::types::ValueOrRange&, sai_u32_range_t&)' lacks explicit unit tests for the error path when min > max. Consider adding tests to verify that invalid ranges are handled correctly.
if (pb_range.range().min() > pb_range.range().max())
Contributor
Author
|
@mukeshmv fyi |
mukeshmv
reviewed
Jun 26, 2025
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Lawrence Lee <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Lawrence Lee <[email protected]>
Collaborator
|
/azp run |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Jul 11, 2025
Collaborator
|
Cherry-pick PR to msft-202506: Azure/sonic-swss.msft#107 |
mssonicbld
added
Included in msft-202506 Branch
and removed
Created PR to msft-202506 Branch
labels
bobby-nexthop
pushed a commit
to bobby-nexthop/sonic-swss
that referenced
this pull request
Jul 24, 2025
…3728) *[DASH] Support trusted VNIs for appliance and ENI objects (sonic-net#3728) What I did Program trusted VNI info to SAI layer for appliance and ENI objects when available Why I did it As per sonic-net/SONiC#1911
vivekrnv
pushed a commit
to vivekrnv/sonic-swss
that referenced
this pull request
Aug 8, 2025
…3728) *[DASH] Support trusted VNIs for appliance and ENI objects (sonic-net#3728) What I did Program trusted VNI info to SAI layer for appliance and ENI objects when available Why I did it As per sonic-net/SONiC#1911
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
…3728) *[DASH] Support trusted VNIs for appliance and ENI objects (sonic-net#3728) What I did Program trusted VNI info to SAI layer for appliance and ENI objects when available Why I did it As per sonic-net/SONiC#1911
balanokia
pushed a commit
to balanokia/sonic-swss
that referenced
this pull request
Nov 17, 2025
…3728) *[DASH] Support trusted VNIs for appliance and ENI objects (sonic-net#3728) What I did Program trusted VNI info to SAI layer for appliance and ENI objects when available Why I did it As per sonic-net/SONiC#1911
theasianpianist
added a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Feb 4, 2026
…3728) *[DASH] Support trusted VNIs for appliance and ENI objects (sonic-net#3728) What I did Program trusted VNI info to SAI layer for appliance and ENI objects when available Why I did it As per sonic-net/SONiC#1911 Signed-off-by: Lawrence Lee <[email protected]>
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
…3728) *[DASH] Support trusted VNIs for appliance and ENI objects (sonic-net#3728) What I did Program trusted VNI info to SAI layer for appliance and ENI objects when available Why I did it As per sonic-net/SONiC#1911 Signed-off-by: Baorong Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
As per sonic-net/SONiC#1911
How I verified it
Run the unit tests
Details if related