[fpmsyncd] support pipeline to flush with a timer#3241
Merged
prsunny merged 4 commits intosonic-net:masterfrom Nov 27, 2024
Merged
[fpmsyncd] support pipeline to flush with a timer#3241prsunny merged 4 commits intosonic-net:masterfrom
prsunny merged 4 commits intosonic-net:masterfrom
Conversation
siqbal1986
reviewed
Sep 17, 2024
a114j0y
force-pushed
the
flushwithtimer
branch
from
f3d9c55 to
f48b154
Compare
Contributor
Author
Its compilation needs this pr to be released |
a114j0y
force-pushed
the
flushwithtimer
branch
2 times, most recently
from
45568ef to
5af28d2
Compare
a114j0y
force-pushed
the
flushwithtimer
branch
from
5af28d2 to
5d0e7b0
Compare
a114j0y
force-pushed
the
flushwithtimer
branch
3 times, most recently
from
30707f8 to
dcc16ad
Compare
a114j0y
force-pushed
the
flushwithtimer
branch
from
2cbc4a2 to
13404ba
Compare
liuh-80
reviewed
Nov 20, 2024
liuh-80
reviewed
Nov 20, 2024
fpmsyncd/fpmsyncd.cpp
Outdated
| int idle = pipeline.getIdleTime(); | ||
|
|
||
| // flush right away | ||
| if (remaining < SMALL_TRAFFIC || idle >= gFlushTimeout || idle <= 0 || scheduled) { |
Contributor
There was a problem hiding this comment.
Why flush with small traffic?
If there are lots of data, the pipeline will not flush until next timeout?
Contributor
Author
There was a problem hiding this comment.
This optimization aims to reduce pipeline flushes in the case of scaled traffic.
Hence for SMALL_TRAFFIC, do immediate flush to maintain the logic before optimization. So that it would not affect the performance when you want to dispatch several critical routes.
But since we skip several flushes, we need to set a timeout to make sure the routes would eventually get flushed, that's when idle >= gFlushTimeout
idle <=0 happens when the system clock is not steady, but since we use steady_clock it shouldn't happen.
Contributor
There was a problem hiding this comment.
#Closed
Suggest add this info to code comments.
a114j0y
force-pushed
the
flushwithtimer
branch
from
7a7005e to
80c961f
Compare
liuh-80
approved these changes
Nov 20, 2024
Contributor
Author
|
This PR also depends on merging PR#954 |
prsunny
previously approved these changes
Nov 22, 2024
dgsudharsan
reviewed
Nov 23, 2024
a114j0y
force-pushed
the
flushwithtimer
branch
from
80c961f to
53a75da
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
a114j0y
force-pushed
the
flushwithtimer
branch
from
1203bc5 to
d223316
Compare
prsunny
approved these changes
Nov 27, 2024
bradh352
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 4, 2024
What I did change the pipeline size for RouteSync modify the fpmsyncd flush behavior so that it could delay the flush with an expiring timer the timer is simulated by setting the timeout for select function
bradh352
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 4, 2024
What I did change the pipeline size for RouteSync modify the fpmsyncd flush behavior so that it could delay the flush with an expiring timer the timer is simulated by setting the timeout for select function
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
What I did change the pipeline size for RouteSync modify the fpmsyncd flush behavior so that it could delay the flush with an expiring timer the timer is simulated by setting the timeout for select function
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
What I did change the pipeline size for RouteSync modify the fpmsyncd flush behavior so that it could delay the flush with an expiring timer the timer is simulated by setting the timeout for select function
stepanblyschak
pushed a commit
to stepanblyschak/sonic-swss
that referenced
this pull request
Jan 27, 2025
What I did change the pipeline size for RouteSync modify the fpmsyncd flush behavior so that it could delay the flush with an expiring timer the timer is simulated by setting the timeout for select function
shiraez
pushed a commit
to Marvell-switching/sonic-swss
that referenced
this pull request
Feb 17, 2025
What I did change the pipeline size for RouteSync modify the fpmsyncd flush behavior so that it could delay the flush with an expiring timer the timer is simulated by setting the timeout for select function
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
What I did change the pipeline size for RouteSync modify the fpmsyncd flush behavior so that it could delay the flush with an expiring timer the timer is simulated by setting the timeout for select function
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
What I did change the pipeline size for RouteSync modify the fpmsyncd flush behavior so that it could delay the flush with an expiring timer the timer is simulated by setting the timeout for select function Signed-off-by: Baorong Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
RouteSyncselectfunctionWhy I did it
APP_DBHow I verified it
measure the performance with PerformanceTimer