Skip to content

Conversation

@kratsg
Copy link
Contributor

@kratsg kratsg commented Oct 14, 2021

Pull Request Description

See #1602 and #1636 (and of course #950).

A specification containing a measurement with "poi": "" should be treated as POI-less. Do not currently support "poi": null at the moment, but this could be considered later if there is desire for it - however the choice of empty string is primarily to align with the XML schema.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Support JSON specifications with empty string for POI by treating as POI-less
* Support poi_name as empty string, in addition to None
* Add test for POI-less workspace

@kratsg kratsg added feat/enhancement New feature or request fix A bug fix schema and spec JSON schema labels Oct 14, 2021
@kratsg kratsg self-assigned this Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1638 (3670949) into master (ae92c25) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1638   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          63       63           
  Lines        4128     4129    +1     
  Branches      566      566           
=======================================
+ Hits         4047     4048    +1     
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 24.99% <0.00%> (-0.01%) ⬇️
unittests 97.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/pdf.py 97.70% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae92c25...3670949. Read the comment docs.

@alexander-held
Copy link
Member

alexander-held commented Oct 15, 2021

@Daniel-Noel this might be interesting for you (and maybe the already merged #1636 even more so).

@kratsg kratsg requested a review from lukasheinrich October 15, 2021 11:39
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍 Thanks!

@matthewfeickert matthewfeickert changed the title feat: POI-less specification support feat: Add POI-less specification support Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat/enhancement New feature or request fix A bug fix schema and spec JSON schema

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants