-
Notifications
You must be signed in to change notification settings - Fork 92
feat: Allow POI-less models via Workspace.model #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1636 +/- ##
==========================================
+ Coverage 97.99% 98.03% +0.04%
==========================================
Files 63 63
Lines 4132 4128 -4
Branches 567 566 -1
==========================================
- Hits 4049 4047 -2
+ Misses 49 48 -1
+ Partials 34 33 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
matthewfeickert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kratsg This is nice. :)
I have two render changes and then a docstring length suggestion, but I like this.
|
related: #1602 |
Co-authored-by: Matthew Feickert <[email protected]>
matthewfeickert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍 Thanks @kratsg!
Pull Request Description
No associated issues. Primarily drop the
poi_namefunctionality inpyhf.Workspace.get_measurementas it is not really used and is kind of a bit weird anyway. Instead, allow for users to specifypoi_nameinpyhf.Workspace.model()in order to override the suggested POI that comes from the measurement they would like to use. This allows a user to use an existing measurement, but override thepoi_name.For example,
pyhf.Workspace.model(poi_name=None)will allow for background-only models to be created frompyhf.Workspacewhich was not something that was allowed in the past.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: