Adaptive playback qos based on recorded metadata #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
emersonknapp
force-pushed
the
emersonknapp/adaptive-publish
branch
3 times, most recently
from
ce2c338 to
7517b38
Compare
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
emersonknapp/adaptive-publish
branch
from
7517b38 to
8fa9fc8
Compare
Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
changed the title
emersonknapp
requested review from
Karsten1987,
piraka9011,
thomas-moulard and
zmichaels11
and removed request for
Karsten1987
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Collaborator
Author
|
Pre-review run to catch any platform-specific build issues
|
zmichaels11
approved these changes
Apr 20, 2020
piraka9011
reviewed
Apr 20, 2020
piraka9011
approved these changes
Apr 20, 2020
Contributor
piraka9011
left a comment
piraka9011
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the extra improvements 👍
zmichaels11
approved these changes
Apr 21, 2020
Contributor
zmichaels11
left a comment
zmichaels11
left a comment
There was a problem hiding this comment.
good luck with windows CI
Collaborator
Author
|
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
emersonknapp/adaptive-publish
branch
from
599852d to
92a6af3
Compare
Collaborator
Author
|
@Karsten1987 did you want to take a look through this one? i think the windows issues are resolved so after another CI run I'm thinking to merge it |
Collaborator
Author
|
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125 - finally!
Moves https://github.com/ros-tooling/aws-roadmap/issues/217 to Done
Use the qos profiles that were recorded into a bag's metadata (if present) to choose a profile for playback. Prefer the user-provided override.