added rosidl_runtime_c depencency #86
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
wjwwood
reviewed
Mar 4, 2020
| <build_depend>rmw_cyclonedds_cpp</build_depend> | ||
| <build_depend>rmw_fastrtps_cpp</build_depend> | ||
| <build_depend>rmw_implementation_cmake</build_depend> | ||
| <build_depend>rosidl_runtime_c</build_depend> |
Member
There was a problem hiding this comment.
Is this package part of the rmw_implementation_packages group?
Contributor
Author
There was a problem hiding this comment.
I think it's part of the rosidl_default_runtime
Member
|
@ahcorde Can you please describe why the dependency is being added? |
Contributor
Author
|
my bad, the dependency should be changed here ros2/rmw#198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the changes introduced in this PR ros2/rosidl#442. The full process can be followed here ros2/rosidl#443
Signed-off-by: ahcorde [email protected]