Skip to content

added rosidl_runtime_c depencency #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

added rosidl_runtime_c depencency #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rmw_implementation/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,16 @@ else()
find_package(rcpputils REQUIRED)
find_package(rcutils REQUIRED)
find_package(rmw REQUIRED)
find_package(rosidl_runtime_c REQUIRED)

add_library(${PROJECT_NAME} SHARED
src/functions.cpp)
ament_target_dependencies(${PROJECT_NAME}
"Poco"
"rcpputils"
"rcutils"
"rmw")
"rmw"
"rosidl_runtime_c")
target_compile_definitions(${PROJECT_NAME}
PUBLIC "DEFAULT_RMW_IMPLEMENTATION=${RMW_IMPLEMENTATION}")
configure_rmw_library(${PROJECT_NAME})
Expand Down
1 change: 1 addition & 0 deletions rmw_implementation/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
<build_depend>rmw_cyclonedds_cpp</build_depend>
<build_depend>rmw_fastrtps_cpp</build_depend>
<build_depend>rmw_implementation_cmake</build_depend>
<build_depend>rosidl_runtime_c</build_depend>
Copy link
Member

@wjwwood wjwwood Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this package part of the rmw_implementation_packages group?

Copy link
Contributor Author

@ahcorde ahcorde Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's part of the rosidl_default_runtime

<!-- end of group dependencies added for bloom -->

<depend>libpoco-dev</depend>
Expand Down