Skip to content

Added the right dependency rosidl_runtime_c instead of rosidl_generator_c #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2020
Merged

Added the right dependency rosidl_runtime_c instead of rosidl_generator_c #198

merged 3 commits into from
Apr 10, 2020

Conversation

@ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 5, 2020

This PR is related to the changes introduced in this PR ros2/rosidl#442. The full process can be followed here ros2/rosidl#443

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde added the enhancement New feature or request label Mar 5, 2020
@ahcorde ahcorde requested review from dirk-thomas and wjwwood March 5, 2020 09:40
@ahcorde ahcorde self-assigned this Mar 5, 2020
This was referenced Mar 5, 2020
Closed
Closed
@wjwwood wjwwood changed the title Added the right dependency rosidl runtime c instead of rosidl generat…or c Added the right dependency rosidl_runtime_c instead of rosidl_generator_c Mar 12, 2020
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 10, 2020

  • Updated all repos involved in this change.
  • Skipping ros1_bridge, qt_*, rqt_*, and rviz_* packages.
  • Testing against test_rclcpp and rosbag2_tests.
  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • One warning made the builds unstable but there is a (PR pending)
CMake Deprecation Warning at /home/jenkins-agent/workspace/ci_linux-aarch64/ws/install/ament_cmake_export_interfaces/share/ament_cmake_export_interfaces/cmake/ament_export_interfaces.cmake:37 (message):
ament_export_interfaces() is deprecated, use ament_export_targets() instead
Call Stack (most recent call first):
CMakeLists.txt:85 (ament_export_interfaces)

In MacOS

  • projectroot.cppcheck

Windows

  • some failures in test_rclcpp

@ahcorde ahcorde merged commit 6c51377 into master Apr 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rosidl_runtime branch April 10, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjwwood wjwwood wjwwood approved these changes

+1 more reviewer

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahcorde ahcorde

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahcorde @wjwwood @dirk-thomas