Skip to content

Conversation

@brawner
Copy link
Contributor

@brawner brawner commented Aug 26, 2020

This just helps clean up rcl_variant_t a little better on finalization, which is important for the fault injection tests.

Depends on #754.

Signed-off-by: Stephen Brawner [email protected]

@brawner brawner force-pushed the brawner/rcl_yaml-set-values-null branch from b8294a7 to 4a633e2 Compare August 29, 2020 00:45
@brawner brawner force-pushed the brawner/rcl_yaml-refactor-srcs branch from 84661d0 to 28a8568 Compare August 29, 2020 00:50
@brawner brawner force-pushed the brawner/rcl_yaml-set-values-null branch from 4a633e2 to f8b7a70 Compare August 31, 2020 17:39
@brawner brawner changed the base branch from brawner/rcl_yaml-refactor-srcs to master August 31, 2020 17:42
@brawner
Copy link
Contributor Author

brawner commented Aug 31, 2020

Rebased onto master for better backportability.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@brawner brawner force-pushed the brawner/rcl_yaml-set-values-null branch from f8b7a70 to a50f3cb Compare August 31, 2020 18:13
@brawner
Copy link
Contributor Author

brawner commented Aug 31, 2020

Rpr build is still waiting on the final release of the rcutils debians in order for fault injection code to compile. All the ci.ros2.org jobs pass otherwise

@brawner brawner merged commit 263bf9d into master Aug 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/rcl_yaml-set-values-null branch August 31, 2020 18:17
brawner added a commit that referenced this pull request Sep 2, 2020
brawner added a commit that referenced this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants