Don't overwrite string data pointer if realloc fails #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2020
Merged
brawner
force-pushed
the
brawner/rcl_yaml-set-values-null
branch
from
b8294a7 to
4a633e2
Compare
brawner
force-pushed
the
brawner/rcl_yaml-add_val_to_string-leak
branch
from
ac7cf6f to
a9bab89
Compare
clalancette
approved these changes
Aug 31, 2020
Blast545
approved these changes
Aug 31, 2020
Contributor
Blast545
left a comment
Blast545
left a comment
There was a problem hiding this comment.
LGTM, but what happened with the PR job of rcl? was it deactivated?
Contributor
No, it didn't trigger because this isn't targeting master. @brawner should we just target master with this PR, and then you can rebase your other work on top? |
Contributor
Author
|
@clalancette I think that's reasonable. The refactor PR (#754) is going to make it much harder to backport fixes like this and #765. |
brawner
force-pushed
the
brawner/rcl_yaml-set-values-null
branch
from
4a633e2 to
f8b7a70
Compare
Signed-off-by: Stephen Brawner <[email protected]>
brawner
force-pushed
the
brawner/rcl_yaml-add_val_to_string-leak
branch
from
a9bab89 to
7cd635f
Compare
brawner
changed the base branch from
brawner/rcl_yaml-set-values-null
to
master
Contributor
Author
|
Rebased onto master, testing
|
Contributor
Author
|
Rpr job still fails waiting for |
delete-merged-branch
bot
deleted the
brawner/rcl_yaml-add_val_to_string-leak
branch
brawner
added a commit
that referenced
this pull request
Oct 5, 2020
Signed-off-by: Stephen Brawner <[email protected]>
Contributor
Author
|
Choosing not to backport this one, since the change is superseded anyway by #784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this memory leak during fault injection tests. It's pretty small, but it prevents the unit tests from being memory leak free.
Signed-off-by: Stephen Brawner [email protected]