Add simple filter tutorials #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter errors in case of incorrect arguments passed to '__init__'. Minor class body style fixes. Signed-off-by: EsipovPA <[email protected]>
ahcorde
requested changes
Dec 1, 2025
| self.count += 1 | ||
|
|
||
| def print_counter_value(self): | ||
| print(f"Filter conter value: {self.count}") |
Contributor
There was a problem hiding this comment.
Suggested change
| print(f"Filter conter value: {self.count}") | |
| print(f"Filter counter value: {self.count}") |
| self.count += 1 | ||
|
|
||
| def print_counter_value(self): | ||
| print(f"Filter conter value: {self.count}") |
Contributor
There was a problem hiding this comment.
Suggested change
| print(f"Filter conter value: {self.count}") | |
| print(f"Filter counter value: {self.count}") |
| self.cache.new_message_callback | ||
| ) | ||
|
|
||
| After the ``pubisher`` and ``Subscruber`` are set up, we initialize ``LastMessageCache`` and ``CounterWithCallback`` filter. |
Contributor
There was a problem hiding this comment.
Suggested change
| After the ``pubisher`` and ``Subscruber`` are set up, we initialize ``LastMessageCache`` and ``CounterWithCallback`` filter. | |
| After the ``publisher`` and ``Subscruber`` are set up, we initialize ``LastMessageCache`` and ``CounterWithCallback`` filter. |
Comment on lines
434
to
453
| Filter conter value: 0 | ||
| Cache is empty | ||
|
|
||
| Filter conter value: 1 | ||
| Last cached message: Example string data № 0 | ||
|
|
||
| Filter conter value: 2 | ||
| Last cached message: Example string data № 1 | ||
|
|
||
| Filter conter value: 3 | ||
| Last cached message: Example string data № 2 | ||
|
|
||
| Filter conter value: 4 | ||
| Last cached message: Example string data № 3 | ||
|
|
||
| Filter conter value: 5 | ||
| Last cached message: Example string data № 4 | ||
|
|
||
| Filter conter value: 6 | ||
| Last cached message: Example string data № 5 |
Contributor
There was a problem hiding this comment.
Suggested change
| Filter conter value: 0 | |
| Cache is empty | |
| Filter conter value: 1 | |
| Last cached message: Example string data № 0 | |
| Filter conter value: 2 | |
| Last cached message: Example string data № 1 | |
| Filter conter value: 3 | |
| Last cached message: Example string data № 2 | |
| Filter conter value: 4 | |
| Last cached message: Example string data № 3 | |
| Filter conter value: 5 | |
| Last cached message: Example string data № 4 | |
| Filter conter value: 6 | |
| Last cached message: Example string data № 5 | |
| Filter counter value: 0 | |
| Cache is empty | |
| Filter counter value: 1 | |
| Last cached message: Example string data № 0 | |
| Filter counter value: 2 | |
| Last cached message: Example string data № 1 | |
| Filter counter value: 3 | |
| Last cached message: Example string data № 2 | |
| Filter counter value: 4 | |
| Last cached message: Example string data № 3 | |
| Filter counter value: 5 | |
| Last cached message: Example string data № 4 | |
| Filter counter value: 6 | |
| Last cached message: Example string data № 5 |
| ... | ||
|
|
||
| def callback_with_args(message: MsgT, *args): | ||
| # # Some work done here |
Contributor
There was a problem hiding this comment.
Suggested change
| # # Some work done here | |
| # Some work done here |
Comment on lines
376
to
378
| <depend>rclpy</depend> | ||
| <depend>message_filters</depend> | ||
| <depend>std_msgs</depend> |
Signed-off-by: EsipovPA <[email protected]>
Signed-off-by: EsipovPA <[email protected]>
EsipovPA
force-pushed
the
add_simple_filter_tutorials
branch
from
d633578 to
47a4de9
Compare
Contributor
Author
|
@ahcorde Thank you for the review! Have applied all the changes that you've proposed. Also alphabetized dependency description sections in other tutorials in a separate commit |
ahcorde
approved these changes
Dec 4, 2025
Contributor
|
I think we can backport this to other distro but the Subscription contructor has a diferrent signature. Do you mind to review it @EsipovPA ? |
Contributor
|
https://github.com/Mergifyio backport kilted jazzy humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
Signed-off-by: EsipovPA <[email protected]> (cherry picked from commit c31a7a9) # Conflicts: # src/message_filters/__init__.py
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
Signed-off-by: EsipovPA <[email protected]> (cherry picked from commit c31a7a9) # Conflicts: # src/message_filters/__init__.py
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
Signed-off-by: EsipovPA <[email protected]> (cherry picked from commit c31a7a9) # Conflicts: # src/message_filters/__init__.py
This was referenced Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a tutorial regarding the usage of
SimpleFilterfor building custom filters in python.Minor fixes to the
Subscriberclass interface and__init__.Relates to #130
Is this user-facing behavior change?
Yes. Better documentation.
Did you use Generative AI?
No, I did not.
Additional Information