Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Dec 4, 2025

Description

Added a tutorial regarding the usage of SimpleFilter for building custom filters in python.
Minor fixes to the Subscriber class interface and __init__.

Relates to #130

Is this user-facing behavior change?

Yes. Better documentation.

Did you use Generative AI?

No, I did not.

Additional Information


This is an automatic backport of pull request #226 done by [Mergify](https://mergify.com).

Signed-off-by: EsipovPA <[email protected]>
(cherry picked from commit c31a7a9)

# Conflicts:
#	src/message_filters/__init__.py
@mergify mergify bot added the conflicts label Dec 4, 2025
@mergify
Copy link
Author

mergify bot commented Dec 4, 2025

Cherry-pick of c31a7a9 has failed:

On branch mergify/bp/jazzy/pr-226
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit c31a7a9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   doc/Tutorials/Approximate-Synchronizer-Python.rst
	modified:   doc/Tutorials/Cache-Cpp.rst
	modified:   doc/Tutorials/Cache-Python.rst
	modified:   doc/Tutorials/Chain-Cpp.rst
	modified:   doc/Tutorials/Chain-Python.rst
	new file:   doc/Tutorials/SimpleFilter-Python.rst
	modified:   doc/tutorials.rst

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/message_filters/__init__.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Dec 4, 2025
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to take a look @@EsipovPA ?

@EsipovPA
Copy link
Contributor

EsipovPA commented Dec 5, 2025

I think this should resolve the conflicts: #233

from rclpy.clock import ROSClock
from rclpy.duration import Duration
from rclpy.logging import LoggingSeverity
from rclpty.node import Node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. rclpty . 🤦‍♂️

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still red @EsipovPA

@EsipovPA
Copy link
Contributor

EsipovPA commented Dec 8, 2025

@ahcorde You are right. I think this fix should do the trick as well as for this PR. I've missed that point that MsgT was added after the release of the humble and jazzy.

@ahcorde
Copy link
Contributor

ahcorde commented Dec 8, 2025

Pulls: #229
Gist: https://gist.githubusercontent.com/ahcorde/43e916352bea4ddc29db1983b2477880/raw/fa1ccf9153957876eca0de250c211f0733f5d4b0/ros2.repos
BUILD args: --packages-above-and-dependencies message_filters
TEST args: --packages-above message_filters
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17713

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit a1c9f25 into jazzy Dec 8, 2025
2 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-226 branch December 8, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants