-
Notifications
You must be signed in to change notification settings - Fork 85
Add simple filter tutorials (backport #226) #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: EsipovPA <[email protected]> (cherry picked from commit c31a7a9) # Conflicts: # src/message_filters/__init__.py
|
Cherry-pick of c31a7a9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
ahcorde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind to take a look @@EsipovPA ?
|
I think this should resolve the conflicts: #233 |
Signed-off-by: EsipovPA <[email protected]>
src/message_filters/__init__.py
Outdated
| from rclpy.clock import ROSClock | ||
| from rclpy.duration import Duration | ||
| from rclpy.logging import LoggingSeverity | ||
| from rclpty.node import Node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. rclpty . 🤦♂️
Signed-off-by: EsipovPA <[email protected]>
ahcorde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is still red @EsipovPA
…#237) Signed-off-by: EsipovPA <[email protected]>
|
Pulls: #229 |
Description
Added a tutorial regarding the usage of
SimpleFilterfor building custom filters in python.Minor fixes to the
Subscriberclass interface and__init__.Relates to #130
Is this user-facing behavior change?
Yes. Better documentation.
Did you use Generative AI?
No, I did not.
Additional Information
This is an automatic backport of pull request #226 done by [Mergify](https://mergify.com).