Skip to content

stop using constructors deprecated in pytest 5.4 #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2020
Merged

stop using constructors deprecated in pytest 5.4 #391

merged 2 commits into from
Mar 18, 2020

Conversation

@rotu
Copy link
Contributor

@rotu rotu commented Mar 13, 2020 

=============================== warnings summary ===============================
/opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:113
/opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:113
  /opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:113: PytestDeprecationWarning: direct construction of Package has been deprecated, please use Package.from_parent
    return pytest.Package(path, parent)

/opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:114: 37 tests with warnings
  /opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:114: PytestDeprecationWarning: direct construction of Module has been deprecated, please use Module.from_parent
    return pytest.Module(path, parent)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
================= 324 passed, 39 warnings in 66.09s (0:01:06) ==================

@rotu
stop using constructors deprecated in pytest5
5cfa54c 
```
=============================== warnings summary ===============================
/opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:113
/opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:113
  /opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:113: PytestDeprecationWarning: direct construction of Package has been deprecated, please use Package.from_parent
    return pytest.Package(path, parent)

/opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:114: 37 tests with warnings
  /opt/ros/master/install/lib/python3.8/site-packages/launch_testing/pytest/hooks.py:114: PytestDeprecationWarning: direct construction of Module has been deprecated, please use Module.from_parent
    return pytest.Module(path, parent)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
================= 324 passed, 39 warnings in 66.09s (0:01:06) ==================
```

Signed-off-by: Dan Rose <[email protected]>
ivanpauno
ivanpauno approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minimal comments, otherwise LGTM!

@ivanpauno
Copy link
Member

ivanpauno commented Mar 18, 2020

@rotu friendly ping.

@rotu
PR feedback
58b4ed0 
Signed-off-by: Dan Rose <[email protected]>
@rotu
Copy link
Contributor Author

rotu commented Mar 18, 2020

@rotu friendly ping.

Thanks! I left my Linux box at the office and forgot to push before I went into self-quarantine. I grabbed the computer, sterilized this commit, and pushed.

@ivanpauno
Copy link
Member

ivanpauno commented Mar 18, 2020 •
edited
Loading

  • Linux Build Status

@ivanpauno
Copy link
Member

ivanpauno commented Mar 18, 2020

sterilized this commit

🤣

@dirk-thomas dirk-thomas changed the title stop using constructors deprecated in pytest5 stop using constructors deprecated in pytest 5.4 Mar 18, 2020
@ivanpauno
Copy link
Member

ivanpauno commented Mar 18, 2020

Failure is unrelated, see ros2/launch_ros#128 (comment).
Merging!

@ivanpauno ivanpauno merged commit ae12701 into ros2:master Mar 18, 2020
@ivanpauno ivanpauno mentioned this pull request Mar 19, 2020
Merged
@dirk-thomas dirk-thomas mentioned this pull request Mar 25, 2020
Merged
mjcarroll pushed a commit that referenced this pull request Aug 7, 2020
@rotu @mjcarroll
stop using constructors deprecated in pytest 5.4 (#391)
525f9f0 
Signed-off-by: Dan Rose <[email protected]>
@sloretz sloretz mentioned this pull request Sep 8, 2020
Closed
sloretz pushed a commit that referenced this pull request Sep 8, 2020
@rotu @sloretz
stop using constructors deprecated in pytest 5.4 (#391)
0d4d8dc 
Signed-off-by: Dan Rose <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
@sloretz sloretz mentioned this pull request Sep 8, 2020
Merged
sloretz added a commit that referenced this pull request Sep 8, 2020
@sloretz @rotu
@clalancette @dirk-thomas
[Eloquent backport] stop using constructors deprecated in pytest 5.4 (#…
b750eda 
…391) Switch to from_parent (partial #421) avoid deprecation warning, use from_parent (#402) (#459)

* stop using constructors deprecated in pytest 5.4 (#391)

Signed-off-by: Dan Rose <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>

* Switch to from_parent to remove deprecation warning.

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>

* avoid deprecation warning, use from_parent (#402)

Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>

Co-authored-by: Dan Rose <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Dirk Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rotu @ivanpauno