Skip to content

Conversation

@sloretz
Copy link
Contributor

@sloretz sloretz commented Sep 8, 2020

Cherry pick of #391 - checking if this fixes #458

Now also includes a cherry-pick of one commit from #421: f1c02f3

Now also includes a cherry-pick of #402

@sloretz sloretz self-assigned this Sep 8, 2020
@sloretz
Copy link
Contributor Author

sloretz commented Sep 8, 2020

Linux CI
Build Status

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
@sloretz sloretz changed the title [Eloquent backport] stop using constructors deprecated in pytest 5.4 (#391) [Eloquent backport] stop using constructors deprecated in pytest 5.4 (#391) Switch to from_parent (partial #421) Sep 8, 2020
@sloretz
Copy link
Contributor Author

sloretz commented Sep 8, 2020

Linux CI after adding partial cherry-pick of #421 Build Status

Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
@sloretz sloretz changed the title [Eloquent backport] stop using constructors deprecated in pytest 5.4 (#391) Switch to from_parent (partial #421) [Eloquent backport] stop using constructors deprecated in pytest 5.4 (#391) Switch to from_parent (partial #421) avoid deprecation warning, use from_parent (#402) Sep 8, 2020
@sloretz
Copy link
Contributor Author

sloretz commented Sep 8, 2020

Linux CI after adding cherry-pick of #402 Build Status

@mjcarroll
Copy link
Member

Supercedes #447

@sloretz
Copy link
Contributor Author

sloretz commented Sep 8, 2020

CI (build: --packages-up-to launch_testing ros2action test: --packages-select launch_testing ros2action ... picked ros2action since it's one of the packages that also showed this deprecation warning by using launch_testing)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Sep 8, 2020

CI including ros2/launch_ros#176 ( build: --packages-up-to launch_testing launch_testing_ros ros2action ros2interface ros2lifecycle ros2msg ros2node ros2pkg ros2service ros2srv ros2test ros2topic test: --packages-select launch_testing launch_testing_ros ros2action ros2interface ros2lifecycle ros2msg ros2node ros2pkg ros2service ros2srv ros2test ros2topic ... that's all packages that are failing in the Eloquent nightlies)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Sep 8, 2020

CI looks ok, I think. There's no good build to compare the arm/OSX/Windows builds to, but none of the test failures appear related to this PR. The linux ones all seem to be an unrelated error: AttributeError: module 'pycodestyle' has no attribute 'break_around_binary_operator', which might have to do with a mismatch in the version of pycodestyle and flake8: https://gitlab.com/pycqa/flake8/-/issues/427 ? There's also a couple pep257 test failures for existing doc strings.

@sloretz sloretz merged commit b750eda into eloquent Sep 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the eloquent_backport_391 branch September 8, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants