[Eloquent] Backport junit xml fixes for updated xunit plugin on ci.ros2.org

[nuclearsandwich]

This PR along with its companion ament/ament_lint#222 should fix Eloquent CI builds failing during the test result parsing stage on ci.ros2.org.

Backports PRs #218 and #225.

[nuclearsandwich]

Combined CI for both this PR and ament/ament_lint#222

• Linux
• Linux-aarch64
• macOS
• Windows

Edit: re-running Windows CI without connext. Let's backport this fix first.

[nuclearsandwich]

@mjcarroll would you mind giving a glance at the finished test results to make sure that the test failures are accepted/acceptable for Eloquent? Windows seems to have quite a few more than the others.

[mjcarroll]

So are there test results that we weren't reporting before? These stand out to me:

• rclpy.flake8.D401 - about imperative mood in doc strings
• A whole slew of results that are rclpy. with a "collection error" https://ci.ros2.org/job/ci_windows/9617/testReport/junit/(root)/rclpy/_30/

There also seem to be a bunch of tests that fail with the same PyTestDeprecationWarning, eg https://ci.ros2.org/job/ci_windows/9617/testReport/junit/(root)/projectroot/test_validate_topic_name/

I don't recall seeing any of these before.

[dirk-thomas]

So are there test results that we weren't reporting before?

I don't think there should be any new test results which didn't exist before. This change is only about updating the XML to comply with the latest Jenkins plugin.

There also seem to be a bunch of tests that fail with the same PyTestDeprecationWarning

You probably need to also backport ros2/launch#391.

[nuclearsandwich]

rclpy.flake8.D401 - about imperative mood in doc strings

This is from ros2/build_farmer#255

One of the recurring challenges with running CI for older distros is that linters keep moving forward and we've previously considered linter fixes not worth backporting by themselves. I usually disregard linter failures when backporting for that reason.