Skip to content

Conversation

@JPLDevMaster
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Primary OS tested on Ubuntu 22.04 LTS
Robotic platform tested on N/A (build fix)
Does this PR contain AI generated software? (No, just a newline really)
Was this PR description generated by AI software? No

Description of contribution in a few bullet points

  • I fixed a typo in the CMakeLists.txt file from the nav2_theta_star_planner package where the nav2_costmap_2d and nav2_util were written together (without a newline).

Description of documentation updates required from your changes

N/A

Description of how this change was tested

  • Performed a clean build using colcon build --symlink-install.

Future work that may be required in bullet points

N/A

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

@JPLDevMaster
Copy link
Contributor Author

Hi!
I am using a ROS2 Humble distribution and therefore tried to create a similar PR to humble_main, however I saw the comment from the mergify bot and am therefore creating this PR to main. Sorry for any inconvenience!

@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JPLDevMaster JPLDevMaster force-pushed the fix/main-cmakelists-typo branch 2 times, most recently from 4a69b13 to 33e348a Compare September 6, 2025 16:39
@JPLDevMaster JPLDevMaster force-pushed the fix/main-cmakelists-typo branch from 33e348a to 38b3d9b Compare September 6, 2025 16:42
@SteveMacenski SteveMacenski merged commit ab4aaf8 into ros-navigation:main Sep 7, 2025
16 checks passed
@JPLDevMaster
Copy link
Contributor Author

Thanks! Could this please be backported to humble?

@SteveMacenski
Copy link
Member

@JPLDevMaster
Copy link
Contributor Author

Sorry, I meant humble_main instead of humble. I assume the difference between them is the backporting of new features to be compatible with the Humble distro, right?
I am working with ROS2 Humble but I need to integrate several new features that are available on humble_main, but not humble.

@SteveMacenski
Copy link
Member

@JPLDevMaster
Copy link
Contributor Author

Thank you!

silanus23 pushed a commit to silanus23/navigation2 that referenced this pull request Sep 18, 2025
SteveMacenski pushed a commit that referenced this pull request Sep 19, 2025
SteveMacenski added a commit that referenced this pull request Sep 20, 2025
* Return early from edge interpolation for zero-length edges (#5453)

* Return early from edge interpolation for zero-length edges

Signed-off-by: Emerson Knapp <[email protected]>

* Move the check and add a test

Signed-off-by: Emerson Knapp <[email protected]>

---------

Signed-off-by: Emerson Knapp <[email protected]>

* nav2_route vizualization marker rendering performance improvement (#5452)

* nav2_route vizualization marker use sphere_list and line_list for rendering performance

Signed-off-by: Emerson Knapp <[email protected]>

* Fix unit test and break out magic constants into named values

Signed-off-by: Emerson Knapp <[email protected]>

---------

Signed-off-by: Emerson Knapp <[email protected]>

* Fix dynamic param SmacPlannerLattice  (#5478)

* Fix SmacPlannerLattice dynamic parameter early exit

Signed-off-by: Tony Najjar <[email protected]>

* remove comment

Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>

* Fix duplicate poses with computePlanThroughPoses (#5488)

* fix-duplicate-poses

Signed-off-by: Tony Najjar <[email protected]>

* Update nav2_planner/src/planner_server.cpp

Co-authored-by: Steve Macenski <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>

* Fix seg fault (#5501)

* Fix segmentation fault

Signed-off-by: Tony Najjar <[email protected]>

* fix linting

Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>

* Route graph vis fixes: Fixes regressions from #5452 (#5507)

* Fixes for route graph

Signed-off-by: SteveMacenski <[email protected]>

* Fix route graph vis

Signed-off-by: SteveMacenski <[email protected]>

---------

Signed-off-by: SteveMacenski <[email protected]>

* Removing openMP dep on MPPI (#5506)

Signed-off-by: SteveMacenski <[email protected]>

* Add debug topic to visualize whether MPPI critic has an effect on costs (#5485)

* Publish criticsStats

Signed-off-by: Tony Najjar <[email protected]>

* linting

Signed-off-by: Tony Najjar <[email protected]>

* change header to stamp

Signed-off-by: Tony Najjar <[email protected]>

* make unique_pointer

Signed-off-by: Tony Najjar <[email protected]>

* typo

Signed-off-by: Tony Najjar <[email protected]>

* Add readme

Signed-off-by: Tony Najjar <[email protected]>

* add to readme

Signed-off-by: Tony Najjar <[email protected]>

* fixes

Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>

* fix(nav2_theta_star_planner): Correct typo in CMakeLists ament_export_dependencies (#5514)

Signed-off-by: JPLDevMaster <[email protected]>

* Fix/dependency and header (#5520)

* Add missing dependency declaration

Signed-off-by: Sushant Chavan <[email protected]>

* Remove unused header

Signed-off-by: Sushant Chavan <[email protected]>

---------

Signed-off-by: Sushant Chavan <[email protected]>

* bump to 1.4.2 for kilted release

Signed-off-by: SteveMacenski <[email protected]>

* Adding critic manager for refactor

Signed-off-by: SteveMacenski <[email protected]>

* Update API refactor

Signed-off-by: SteveMacenski <[email protected]>

* API updates

Signed-off-by: SteveMacenski <[email protected]>

* Fix formatting issues in critic_manager.hpp

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: SteveMacenski <[email protected]>
Signed-off-by: JPLDevMaster <[email protected]>
Signed-off-by: Sushant Chavan <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Emerson Knapp <[email protected]>
Co-authored-by: Tony Najjar <[email protected]>
Co-authored-by: João Penha Lopes <[email protected]>
Co-authored-by: Sushant Chavan <[email protected]>
BCKSELFDRIVEWORLD pushed a commit to BCKSELFDRIVEWORLD/navigation2 that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants