-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(nav2_theta_star_planner): Correct typo in CMakeLists ament_export_dependencies #5514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nav2_theta_star_planner): Correct typo in CMakeLists ament_export_dependencies #5514
Conversation
|
Hi! |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
4a69b13 to
33e348a
Compare
…_dependencies Signed-off-by: JPLDevMaster <[email protected]>
33e348a to
38b3d9b
Compare
|
Thanks! Could this please be backported to humble? |
|
I don’t think this is a problem on Humble: https://github.com/ros-navigation/navigation2/blob/humble/nav2_theta_star_planner/CMakeLists.txt |
|
Sorry, I meant humble_main instead of humble. I assume the difference between them is the backporting of new features to be compatible with the Humble distro, right? |
|
Thank you! |
…_dependencies (ros-navigation#5514) Signed-off-by: JPLDevMaster <[email protected]>
…_dependencies (#5514) Signed-off-by: JPLDevMaster <[email protected]>
* Return early from edge interpolation for zero-length edges (#5453) * Return early from edge interpolation for zero-length edges Signed-off-by: Emerson Knapp <[email protected]> * Move the check and add a test Signed-off-by: Emerson Knapp <[email protected]> --------- Signed-off-by: Emerson Knapp <[email protected]> * nav2_route vizualization marker rendering performance improvement (#5452) * nav2_route vizualization marker use sphere_list and line_list for rendering performance Signed-off-by: Emerson Knapp <[email protected]> * Fix unit test and break out magic constants into named values Signed-off-by: Emerson Knapp <[email protected]> --------- Signed-off-by: Emerson Knapp <[email protected]> * Fix dynamic param SmacPlannerLattice (#5478) * Fix SmacPlannerLattice dynamic parameter early exit Signed-off-by: Tony Najjar <[email protected]> * remove comment Signed-off-by: Tony Najjar <[email protected]> --------- Signed-off-by: Tony Najjar <[email protected]> * Fix duplicate poses with computePlanThroughPoses (#5488) * fix-duplicate-poses Signed-off-by: Tony Najjar <[email protected]> * Update nav2_planner/src/planner_server.cpp Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: Tony Najjar <[email protected]> --------- Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Steve Macenski <[email protected]> * Fix seg fault (#5501) * Fix segmentation fault Signed-off-by: Tony Najjar <[email protected]> * fix linting Signed-off-by: Tony Najjar <[email protected]> --------- Signed-off-by: Tony Najjar <[email protected]> * Route graph vis fixes: Fixes regressions from #5452 (#5507) * Fixes for route graph Signed-off-by: SteveMacenski <[email protected]> * Fix route graph vis Signed-off-by: SteveMacenski <[email protected]> --------- Signed-off-by: SteveMacenski <[email protected]> * Removing openMP dep on MPPI (#5506) Signed-off-by: SteveMacenski <[email protected]> * Add debug topic to visualize whether MPPI critic has an effect on costs (#5485) * Publish criticsStats Signed-off-by: Tony Najjar <[email protected]> * linting Signed-off-by: Tony Najjar <[email protected]> * change header to stamp Signed-off-by: Tony Najjar <[email protected]> * make unique_pointer Signed-off-by: Tony Najjar <[email protected]> * typo Signed-off-by: Tony Najjar <[email protected]> * Add readme Signed-off-by: Tony Najjar <[email protected]> * add to readme Signed-off-by: Tony Najjar <[email protected]> * fixes Signed-off-by: Tony Najjar <[email protected]> --------- Signed-off-by: Tony Najjar <[email protected]> * fix(nav2_theta_star_planner): Correct typo in CMakeLists ament_export_dependencies (#5514) Signed-off-by: JPLDevMaster <[email protected]> * Fix/dependency and header (#5520) * Add missing dependency declaration Signed-off-by: Sushant Chavan <[email protected]> * Remove unused header Signed-off-by: Sushant Chavan <[email protected]> --------- Signed-off-by: Sushant Chavan <[email protected]> * bump to 1.4.2 for kilted release Signed-off-by: SteveMacenski <[email protected]> * Adding critic manager for refactor Signed-off-by: SteveMacenski <[email protected]> * Update API refactor Signed-off-by: SteveMacenski <[email protected]> * API updates Signed-off-by: SteveMacenski <[email protected]> * Fix formatting issues in critic_manager.hpp Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: Emerson Knapp <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Signed-off-by: SteveMacenski <[email protected]> Signed-off-by: JPLDevMaster <[email protected]> Signed-off-by: Sushant Chavan <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: Emerson Knapp <[email protected]> Co-authored-by: Tony Najjar <[email protected]> Co-authored-by: João Penha Lopes <[email protected]> Co-authored-by: Sushant Chavan <[email protected]>
…_dependencies (ros-navigation#5514) Signed-off-by: JPLDevMaster <[email protected]>
Basic Info
Description of contribution in a few bullet points
nav2_theta_star_plannerpackage where thenav2_costmap_2dandnav2_utilwere written together (without a newline).Description of documentation updates required from your changes
N/A
Description of how this change was tested
Future work that may be required in bullet points
N/A
For Maintainers:
backport-*.