-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Change to goal checker orientation for yaw angle #4988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SteveMacenski
merged 1 commit into
ros-navigation:main
from
RasmusLar:fix/progressCheckerTests
Mar 17, 2025
Merged
Change to goal checker orientation for yaw angle #4988
SteveMacenski
merged 1 commit into
ros-navigation:main
from
RasmusLar:fix/progressCheckerTests
Mar 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed discrepancy in goal checker orientation, which was checking for < tolerance instead of <= tolerance, as all the other limit checks are. - Reduced tolerance time for the progress checker unit tests to 0.1 seconds, to reduce test runtime from ~17 to ~7 seconds. Signed-off-by: Rasmus Larsson <[email protected]>
e7335af to
c7bb826
Compare
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
SteveMacenski
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Nils-ChristianIseke
pushed a commit
to Nils-ChristianIseke/navigation2
that referenced
this pull request
Mar 21, 2025
- Fixed discrepancy in goal checker orientation, which was checking for < tolerance instead of <= tolerance, as all the other limit checks are. - Reduced tolerance time for the progress checker unit tests to 0.1 seconds, to reduce test runtime from ~17 to ~7 seconds. Signed-off-by: Rasmus Larsson <[email protected]> Signed-off-by: Nils-ChristianIseke <[email protected]>
SteveMacenski
pushed a commit
that referenced
this pull request
Apr 15, 2025
- Fixed discrepancy in goal checker orientation, which was checking for < tolerance instead of <= tolerance, as all the other limit checks are. - Reduced tolerance time for the progress checker unit tests to 0.1 seconds, to reduce test runtime from ~17 to ~7 seconds. Signed-off-by: Rasmus Larsson <[email protected]>
SteveMacenski
added a commit
that referenced
this pull request
Apr 15, 2025
* Add short delay before lookup transform in polygon test (#4939) * Add short delay before lookup transform Signed-off-by: mini-1235 <[email protected]> * Fix linting Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> * Populate stamped command message with now timestamp, if velocity timed out. (#4959) Signed-off-by: Georg Flick <[email protected]> * Integrate ClearCostmapExceptRegion and ClearCostmapAroundRobot Services into the API (#4962) * Add ClearCostmapExceptRegion and ClearCostmapAroundRobot services to BasicNavigator API Signed-off-by: BCKSELFDRIVEWORLD <[email protected]> * typo ament_flake8 Signed-off-by: BCKSELFDRIVEWORLD <[email protected]> * type fix ament_flake Signed-off-by: BCKSELFDRIVEWORLD <[email protected]> --------- Signed-off-by: BCKSELFDRIVEWORLD <[email protected]> * Fix urls in node hybrid (#4973) Signed-off-by: mattbooker <[email protected]> * Use main function to replace global variable in gtest. (#4978) Signed-off-by: ChenYing Kuo <[email protected]> * nav2_behavior_tree: fix input port parsing error in AreErrorCodesPresent (#4986) The getInput method does not support std::set<uint16_t> parsing. So, let's replace the type of the input port by std::vector<int> which is supported, and convert the list to a std::set<uint16_t>. This commit fixes issue #4985. Signed-off-by: Dylan De Coeyer <[email protected]> * Change to goal checker orientation for yaw angle (#4988) - Fixed discrepancy in goal checker orientation, which was checking for < tolerance instead of <= tolerance, as all the other limit checks are. - Reduced tolerance time for the progress checker unit tests to 0.1 seconds, to reduce test runtime from ~17 to ~7 seconds. Signed-off-by: Rasmus Larsson <[email protected]> * Declare_parameter_if_not_declared in docking navigator (#5023) Signed-off-by: Alberto Tudela <[email protected]> * bumping to 1.3.6 for release Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Georg Flick <[email protected]> Signed-off-by: BCKSELFDRIVEWORLD <[email protected]> Signed-off-by: mattbooker <[email protected]> Signed-off-by: ChenYing Kuo <[email protected]> Signed-off-by: Dylan De Coeyer <[email protected]> Signed-off-by: Rasmus Larsson <[email protected]> Signed-off-by: Alberto Tudela <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: mini-1235 <[email protected]> Co-authored-by: Georg Flick <[email protected]> Co-authored-by: Burak Can Kaya <[email protected]> Co-authored-by: Matthew Booker <[email protected]> Co-authored-by: ChenYing Kuo (CY) <[email protected]> Co-authored-by: DylanDeCoeyer-Quimesis <[email protected]> Co-authored-by: RasmusLar <[email protected]> Co-authored-by: Alberto Tudela <[email protected]>
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
- Fixed discrepancy in goal checker orientation, which was checking for < tolerance instead of <= tolerance, as all the other limit checks are. - Reduced tolerance time for the progress checker unit tests to 0.1 seconds, to reduce test runtime from ~17 to ~7 seconds. Signed-off-by: Rasmus Larsson <[email protected]> Signed-off-by: stevedanomodolor <[email protected]>
SakshayMahna
pushed a commit
to SakshayMahna/navigation2
that referenced
this pull request
Jun 8, 2025
- Fixed discrepancy in goal checker orientation, which was checking for < tolerance instead of <= tolerance, as all the other limit checks are. - Reduced tolerance time for the progress checker unit tests to 0.1 seconds, to reduce test runtime from ~17 to ~7 seconds. Signed-off-by: Rasmus Larsson <[email protected]> Signed-off-by: Sakshay Mahna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
< toleranceinstead of<= tolerance, as all the other limit checks are.Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers: