-
Notifications
You must be signed in to change notification settings - Fork 1.6k
nav2_behavior_tree: fix input port parsing error in AreErrorCodesPresent #4986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nav2_behavior_tree: fix input port parsing error in AreErrorCodesPresent #4986
Conversation
5f6c47a to
2829e0e
Compare
SteveMacenski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty irritated that this wasn't tested thoroughly by the original developer, but I see looking at the unit tests for this node how this got based us. This was the base class of the derived Controller/Planner/Smoother variants that set the values in their constructor based on contextual knowledge, so I see how this may not have been appropriately tested as a stand alone node. That's my bad in quality control, sorry!
|
I think the unit test just needs the input type updated to vector: |
The getInput method does not support std::set<uint16_t> parsing. So, let's replace the type of the input port by std::vector<int> which is supported, and convert the list to a std::set<uint16_t>. This commit fixes issue ros-navigation#4985. Signed-off-by: Dylan De Coeyer <[email protected]>
2829e0e to
4336e10
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…ent (ros-navigation#4986) The getInput method does not support std::set<uint16_t> parsing. So, let's replace the type of the input port by std::vector<int> which is supported, and convert the list to a std::set<uint16_t>. This commit fixes issue ros-navigation#4985. Signed-off-by: Dylan De Coeyer <[email protected]> Signed-off-by: Nils-ChristianIseke <[email protected]>
…ent (#4986) The getInput method does not support std::set<uint16_t> parsing. So, let's replace the type of the input port by std::vector<int> which is supported, and convert the list to a std::set<uint16_t>. This commit fixes issue #4985. Signed-off-by: Dylan De Coeyer <[email protected]>
* Add short delay before lookup transform in polygon test (#4939) * Add short delay before lookup transform Signed-off-by: mini-1235 <[email protected]> * Fix linting Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> * Populate stamped command message with now timestamp, if velocity timed out. (#4959) Signed-off-by: Georg Flick <[email protected]> * Integrate ClearCostmapExceptRegion and ClearCostmapAroundRobot Services into the API (#4962) * Add ClearCostmapExceptRegion and ClearCostmapAroundRobot services to BasicNavigator API Signed-off-by: BCKSELFDRIVEWORLD <[email protected]> * typo ament_flake8 Signed-off-by: BCKSELFDRIVEWORLD <[email protected]> * type fix ament_flake Signed-off-by: BCKSELFDRIVEWORLD <[email protected]> --------- Signed-off-by: BCKSELFDRIVEWORLD <[email protected]> * Fix urls in node hybrid (#4973) Signed-off-by: mattbooker <[email protected]> * Use main function to replace global variable in gtest. (#4978) Signed-off-by: ChenYing Kuo <[email protected]> * nav2_behavior_tree: fix input port parsing error in AreErrorCodesPresent (#4986) The getInput method does not support std::set<uint16_t> parsing. So, let's replace the type of the input port by std::vector<int> which is supported, and convert the list to a std::set<uint16_t>. This commit fixes issue #4985. Signed-off-by: Dylan De Coeyer <[email protected]> * Change to goal checker orientation for yaw angle (#4988) - Fixed discrepancy in goal checker orientation, which was checking for < tolerance instead of <= tolerance, as all the other limit checks are. - Reduced tolerance time for the progress checker unit tests to 0.1 seconds, to reduce test runtime from ~17 to ~7 seconds. Signed-off-by: Rasmus Larsson <[email protected]> * Declare_parameter_if_not_declared in docking navigator (#5023) Signed-off-by: Alberto Tudela <[email protected]> * bumping to 1.3.6 for release Signed-off-by: Steve Macenski <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Georg Flick <[email protected]> Signed-off-by: BCKSELFDRIVEWORLD <[email protected]> Signed-off-by: mattbooker <[email protected]> Signed-off-by: ChenYing Kuo <[email protected]> Signed-off-by: Dylan De Coeyer <[email protected]> Signed-off-by: Rasmus Larsson <[email protected]> Signed-off-by: Alberto Tudela <[email protected]> Signed-off-by: Steve Macenski <[email protected]> Co-authored-by: mini-1235 <[email protected]> Co-authored-by: Georg Flick <[email protected]> Co-authored-by: Burak Can Kaya <[email protected]> Co-authored-by: Matthew Booker <[email protected]> Co-authored-by: ChenYing Kuo (CY) <[email protected]> Co-authored-by: DylanDeCoeyer-Quimesis <[email protected]> Co-authored-by: RasmusLar <[email protected]> Co-authored-by: Alberto Tudela <[email protected]>
…ent (ros-navigation#4986) The getInput method does not support std::set<uint16_t> parsing. So, let's replace the type of the input port by std::vector<int> which is supported, and convert the list to a std::set<uint16_t>. This commit fixes issue ros-navigation#4985. Signed-off-by: Dylan De Coeyer <[email protected]> Signed-off-by: stevedanomodolor <[email protected]>
…ent (ros-navigation#4986) The getInput method does not support std::set<uint16_t> parsing. So, let's replace the type of the input port by std::vector<int> which is supported, and convert the list to a std::set<uint16_t>. This commit fixes issue ros-navigation#4985. Signed-off-by: Dylan De Coeyer <[email protected]> Signed-off-by: Sakshay Mahna <[email protected]>
The getInput method does not support std::set<uint16_t> parsing. So, let's replace the type of the input port by std::vector which is supported, and convert the list to a std::set<uint16_t>.
This commit fixes issue #4985.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers: