Cleanup from #107 #158
Merged
Cleanup from #107 #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjeronimo
approved these changes
Oct 11, 2018
ghost
reviewed
Oct 11, 2018
| */ | ||
| #ifndef nav2_costmap_2d_ARRAY_PARSER_H | ||
| #define nav2_costmap_2d_ARRAY_PARSER_H | ||
| #ifndef NAV2_COSTMAP_2D_ARRAY_PARSER_H |
There was a problem hiding this comment.
Does this pass cpplint? I thought it wanted two _ between the path and the filename part eg NAV2_COSTMAP_2D__ARRAY_PARSER_H
There was a problem hiding this comment.
This directory has a lot of issues still w/ the linters. Since the spirit of this PR was directory re-org, I suggest leaving that for a separate PR.
Member
Author
There was a problem hiding this comment.
fixed all to have double underscores.
| *********************************************************************/ | ||
| #ifndef nav2_costmap_2d_nav2_costmap_2d_ROS_H_ | ||
| #define nav2_costmap_2d_nav2_costmap_2d_ROS_H_ | ||
| #ifndef NAV2_COSTMAP_2D_nav2_costmap_2d_ROS_H_ |
There was a problem hiding this comment.
I think this should be NAV2_COSTMAP_2D__COSTMAP_2D_ROS_H_ That is, uppercase filename part, no nav2 prefix on the filename part and double underscores.
Collaborator
There was a problem hiding this comment.
@SteveMacenski - can you please make this change and we can get this approved
Member
Author
|
changed guards to |
ghost
approved these changes
Oct 15, 2018
ghost
merged commit
ghost
pushed a commit
to logivations/navigation2
that referenced
this pull request
Mar 7, 2022
mini-1235
pushed a commit
to mini-1235/navigation2
that referenced
this pull request
Feb 5, 2025
* adding documentation for nav through poses PR * adding new params for nav through poses
mini-1235
pushed a commit
to mini-1235/navigation2
that referenced
this pull request
Feb 5, 2025
* corrected the BT example to the current one * fixed xml code block formatting * completed first portion of custom_bt tutorial * added NavigateWithReplanning explaination * added recovery fallback tutorial * Apply suggestions from Steve's code review Co-authored-by: Steve Macenski <[email protected]> * Added BT Custom Node Walk Through (#1) * adding reference to the getting started guide * fixed xml indentation * adding images, test to see how it renders * fixing XML, and BT rendering * adding overview of custom BT nodes * added pictures for pipeline sequence * fixed typos on image, and guide * added recovery node explaination * addding round robin explaination * getting rid of build folder and vscode folder * Editing, Added Explanation through Recovery subtree (ros-navigation#2) * Apply suggestions from code review Co-authored-by: Steve Macenski <[email protected]> * Update Foxy.rst * Nav through poses2: Adding parameters (ros-navigation#158) * adding documentation for nav through poses PR * adding new params for nav through poses * attempt at moving custom Nav2 BT nodes to it's own section * attempt to fix the pipe rendering issue * changing references so that they are navigate to pose with replanning and recovery * putting new page in a folder in an attempt to get the BT XML page working * fix page link for config guide, play around to render bullets * brushing up in response to comments * fixing link so that they lead directly to the specific nodes * correcting minor typos and comments * moving to main behavior tree section * fixing typo in index so that TOC works * trying relative path in case that fixes the link to nav2_specific_nodes * still trying to link to overview/specific_nodes * ok hopefully this is the final time here, successful link * fixing images Co-authored-by: Steve Macenski <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that's the end of that PR. Let me know if there's anything else I missed.
S