Merged
Conversation
* Fix bug with absolute paths and getDestPath * Fix bug in the test * remove .only
* Bump dependencies to remove audit issues * Fix some build issues
…ssage (#180) * Identify when a 577 error is thrown, send a new developer friendly message * Add unit test to get 100% coverage. Testing the publish 577 response code * Update src/Errors.ts Co-authored-by: Bronley Plumb <bronley@gmail.com> * Rename the 577 error to updateCheckRequiredError. Pass the underlying error as the cause so developers can trace back to the root cause of the error --------- Co-authored-by: Bronley Plumb <bronley@gmail.com>
* Fix issues detecting when a device needs to check for updates * Fix failing test * Improved error types * Add unit tests to get to 100% coverage --------- Co-authored-by: Christian Holbrook <cholbrook@fubo.tv>
* fixed an issue with 577 error codes * increased test coverage * Get tests back to full covrage --------- Co-authored-by: Christopher Dwyer-Perkins <chris@inverted-solutions.com>
# Conflicts: # CHANGELOG.md # package-lock.json # package.json # src/Errors.ts # src/RokuDeploy.spec.ts # src/RokuDeploy.ts
TwitchBronBron
approved these changes
Apr 29, 2025
Member
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
Nice. Thanks for getting this all fixed up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge branch 'master' into v4
Conflicts:
CHANGELOG.md
package-lock.json
package.json
src/Errors.ts
src/RokuDeploy.spec.ts
src/RokuDeploy.ts