Fix issues with detecting "check for updates required"#181
Merged
TwitchBronBron merged 4 commits intomasterfrom Dec 4, 2024
Merged
Fix issues with detecting "check for updates required"#181TwitchBronBron merged 4 commits intomasterfrom
TwitchBronBron merged 4 commits intomasterfrom
Conversation
Christian-Holbrook
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves upon #180 . Apparently the device actually returns status code
200instead of577.577is some other type of error, we should handle that separately.This now checks for
200responses to see if the exact text'Failed to check for software update'is found. If so, that's when we throw theUpdateCheckRequiredErrorerror.