fixes #175 - updated regex to find a signed package on /plugin_package page#176
Merged
TwitchBronBron merged 2 commits intorokucommunity:masterfrom Oct 9, 2024
Merged
Conversation
…/plugin_package` page
TwitchBronBron
approved these changes
Oct 9, 2024
Member
TwitchBronBron
left a comment
There was a problem hiding this comment.
Hey, this is great! Thanks for your contribution.
I pushed a small change that includes a test for the old logic, and added the old logic back in as a fallback if the json approach doesn't work. Since this is a fairly significant change (logically) from how we derive this value, I'm hesitant to 100% switch to the new way, so having the fallback feels like a good compromise.
Do you mind pulling this version down and testing it? Once you're good with my changes, I'm happy to merge and cut a release.
Contributor
Author
|
@TwitchBronBron yes, the fallback is a good idea. tested locally on one device with sdcard and without. works fine for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #175
the current implementation tries to parse a package's remote path from
<a .../>on/plugin_package. that link is not always correct ( for example if you device has a sdcard installed )/plugin_packagepage response always havevar params = JSON.parse('......')line. And the actual link ( when you opens the page in the browser ) built from the following js