Wait for StorageCluster to be ready #649

betoredhat · 2025-04-16T19:19:28Z

SUMMARY

StorageCluster takes around 10 minutes to reconcile
Use full device ID in the hosts template

ISSUE TYPE

Nominal change

Tests

TestBos2: virt libvirt:components=ocp?tags%3abuild%3aga - https://www.distributed-ci.io/jobs/fe8b712c-a59e-4d35-bde6-e9e402e39aaf

Test-hints: no-check

coderabbitai · 2025-04-16T19:19:35Z

Walkthrough

A new task was appended to the OpenShift storage operator playbook to implement a wait mechanism that ensures the StorageCluster resource reaches the "Ready" phase before the playbook proceeds. The task employs the kubernetes.core.k8s_info module to repeatedly query the status of the StorageCluster, retrying up to 40 times with 30-second intervals, and only continues once the resource is confirmed to be ready. Additionally, a template file was updated to modify the value of the local_storage_devices variable when local storage operator (LSO) is enabled, changing the device identifier string used.

Changes

File(s)	Change Summary
roles/odf_setup/tasks/openshift-storage-operator.yml	Added a task to wait for the StorageCluster resource to reach the "Ready" phase using retries.
roles/ocp_on_libvirt/templates/hosts.j2	Modified the `local_storage_devices` variable value when `enable_lso` is true to a different device string.

Suggested reviewers

manurodriguez

Poem

A cluster waits, the playbook stalls,
For "Ready" status in the storage halls.
Forty checks, with patience true,
Thirty seconds, then retry anew.
When all is set, the tasks resume—
The rabbit hops, no hint of gloom!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3ddf01a and e531138.

📒 Files selected for processing (1)

roles/odf_setup/tasks/openshift-storage-operator.yml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

roles/odf_setup/tasks/openshift-storage-operator.yml

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Sanity Check (stable-2.17)
GitHub Check: Sanity Check (stable-2.9)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

softwarefactory-project-zuul · 2025-04-16T19:22:40Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/c100f54bbf984ef0b53d55c4214e0882

✔️ dci-rpm-build-el8 SUCCESS in 2m 49s
✔️ dci-rpm-build-el9 SUCCESS in 2m 35s

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (2)

roles/odf_setup/tasks/openshift-storage-operator.yml (2)
84-84: Task name grammar and clarity refinement
The name could be more grammatically clear and align with other task names. For example:
- name: Wait up to 20 mins Storage Cluster to be ready
+ name: Wait for StorageCluster to be ready (up to 20 minutes)
90-92: Consistent and descriptive register variable naming
The registration variable _of_sc uses a leading underscore and an abbreviation that may be less readable. For consistency with earlier tasks (e.g., ocs_health_status), consider renaming it to something like storagecluster_info:
-  register: _of_sc
+  register: storagecluster_info

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82d25a8 and 7905fb6.

📒 Files selected for processing (1)

roles/odf_setup/tasks/openshift-storage-operator.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Sanity Check (stable-2.17)
GitHub Check: Sanity Check (stable-2.9)

roles/odf_setup/tasks/openshift-storage-operator.yml

softwarefactory-project-zuul · 2025-04-16T19:35:10Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/08d57893b944439dbabf727cfdbfa564

✔️ dci-rpm-build-el8 SUCCESS in 2m 52s
✔️ dci-rpm-build-el9 SUCCESS in 2m 23s

betoredhat · 2025-04-16T19:45:56Z

recheck

softwarefactory-project-zuul · 2025-04-16T19:49:12Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/2cbd6df1e88f40b59ba0252b6c14c775

✔️ dci-rpm-build-el8 SUCCESS in 2m 46s
✔️ dci-rpm-build-el9 SUCCESS in 2m 39s

betoredhat · 2025-04-16T19:55:45Z

recheck

softwarefactory-project-zuul · 2025-04-16T19:58:55Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/a212c78ceaa44e75ad343cbf6b608d15

✔️ dci-rpm-build-el8 SUCCESS in 2m 56s
✔️ dci-rpm-build-el9 SUCCESS in 2m 29s

betoredhat · 2025-04-16T21:40:12Z

recheck

dcibot · 2025-04-16T21:40:17Z

from change #649:

ERROR no DCI job found

softwarefactory-project-zuul · 2025-04-16T21:42:39Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/46264551655b40ebaeb1f50726a7cbf4

✔️ dci-rpm-build-el8 SUCCESS in 2m 51s
✔️ dci-rpm-build-el9 SUCCESS in 2m 47s

betoredhat · 2025-04-16T21:55:09Z

recheck

softwarefactory-project-zuul · 2025-04-16T21:58:12Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/3c52920e64a2424a82bf7ea8679c3860

✔️ dci-rpm-build-el8 SUCCESS in 2m 46s
✔️ dci-rpm-build-el9 SUCCESS in 2m 26s

roles/odf_setup/tasks/openshift-storage-operator.yml

Co-authored-by: Tony Garcia <[email protected]>

betoredhat · 2025-04-16T22:42:02Z

recheck

dcibot · 2025-04-16T22:42:07Z

from change #649:

ERROR no DCI job found

softwarefactory-project-zuul · 2025-04-16T22:44:06Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/751e6c741bf44eccbdbd6b028951aa73

✔️ dci-rpm-build-el8 SUCCESS in 2m 47s
✔️ dci-rpm-build-el9 SUCCESS in 2m 22s

dcibot · 2025-04-17T01:11:27Z

from change #649:

RUNNING https://www.distributed-ci.io/jobs/96f9b990-0814-4291-b763-a6ac0fdfdde9/jobStates

betoredhat · 2025-04-17T05:05:30Z

recheck

softwarefactory-project-zuul · 2025-04-17T05:08:35Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/1bb28662ce1d4884a065a540d5fa621e

✔️ dci-rpm-build-el8 SUCCESS in 2m 50s
✔️ dci-rpm-build-el9 SUCCESS in 2m 27s

dcibot · 2025-04-17T05:23:48Z

from change #649:

FAILURE https://www.distributed-ci.io/jobs/347177b3-8c64-4b17-b87e-e5855aee1395/jobStates

tonyskapunk · 2025-04-17T11:23:41Z

retest

dcibot · 2025-04-17T11:42:27Z

from change #649:

FAILURE https://www.distributed-ci.io/jobs/a98d6ee9-820a-4a7a-a62e-4f01dc525f36/jobStates

betoredhat · 2025-04-17T12:12:11Z

recheck

softwarefactory-project-zuul · 2025-04-17T12:15:17Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/571f64b4c7df48a09f81e271ba7cef52

✔️ dci-rpm-build-el8 SUCCESS in 2m 53s
✔️ dci-rpm-build-el9 SUCCESS in 2m 24s

dcibot · 2025-04-17T12:31:42Z

from change #649:

FAILURE https://www.distributed-ci.io/jobs/53ed79ed-1aec-466c-9dda-44d4763527b7/jobStates

tonyskapunk · 2025-04-17T12:43:11Z

retest

dcibot · 2025-04-17T14:29:04Z

from change #649:

SUCCESS https://www.distributed-ci.io/jobs/fe8b712c-a59e-4d35-bde6-e9e402e39aaf/jobStates

betoredhat requested a review from a team as a code owner April 16, 2025 19:19

coderabbitai bot reviewed Apr 16, 2025

View reviewed changes

roles/odf_setup/tasks/openshift-storage-operator.yml Outdated Show resolved Hide resolved

roles/odf_setup/tasks/openshift-storage-operator.yml Show resolved Hide resolved

betoredhat force-pushed the wait_storagecluster branch from 7905fb6 to 690fd22 Compare April 16, 2025 19:32

Wait for StorageCluster to be ready

3ddf01a

betoredhat force-pushed the wait_storagecluster branch from 690fd22 to 3ddf01a Compare April 16, 2025 21:39

betoredhat requested a review from manurodriguez April 16, 2025 21:47

tonyskapunk requested changes Apr 16, 2025

View reviewed changes

roles/odf_setup/tasks/openshift-storage-operator.yml Outdated Show resolved Hide resolved

Update roles/odf_setup/tasks/openshift-storage-operator.yml

e531138

Co-authored-by: Tony Garcia <[email protected]>

tonyskapunk approved these changes Apr 17, 2025

View reviewed changes

tonyskapunk added this pull request to the merge queue Apr 17, 2025

Merged via the queue into main with commit e15b136 Apr 17, 2025
8 checks passed

tonyskapunk deleted the wait_storagecluster branch April 17, 2025 17:14

coderabbitai bot mentioned this pull request May 8, 2025

Include retry to check OCS CRD is available #670

Merged

This was referenced Jun 25, 2025

Validate cephobjectstoreuser objects #716

Merged

[odf_setuo] Reduce retries for cephobjectstoreusers #719

Merged

coderabbitai bot mentioned this pull request Aug 4, 2025

[odf_setup] increase retries for StorageCluster resource to be ready #761

Merged

1 task

coderabbitai bot mentioned this pull request Sep 11, 2025

increase wait for ocs #780

Merged

Wait for StorageCluster to be ready #649

Wait for StorageCluster to be ready #649

Uh oh!

Conversation

betoredhat commented Apr 16, 2025 • edited by tonyskapunk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

ISSUE TYPE

Tests

Uh oh!

coderabbitai bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

softwarefactory-project-zuul bot commented Apr 16, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Apr 16, 2025

Uh oh!

betoredhat commented Apr 16, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 16, 2025

Uh oh!

betoredhat commented Apr 16, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 16, 2025

Uh oh!

betoredhat commented Apr 16, 2025

Uh oh!

dcibot commented Apr 16, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 16, 2025

Uh oh!

betoredhat commented Apr 16, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 16, 2025

Uh oh!

Uh oh!

betoredhat commented Apr 16, 2025

Uh oh!

dcibot commented Apr 16, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 16, 2025

Uh oh!

dcibot commented Apr 17, 2025

Uh oh!

betoredhat commented Apr 17, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 17, 2025

Uh oh!

dcibot commented Apr 17, 2025

Uh oh!

tonyskapunk commented Apr 17, 2025

Uh oh!

dcibot commented Apr 17, 2025

Uh oh!

betoredhat commented Apr 17, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 17, 2025

Uh oh!

dcibot commented Apr 17, 2025

Uh oh!

tonyskapunk commented Apr 17, 2025

Uh oh!

dcibot commented Apr 17, 2025

Uh oh!

Uh oh!

Reviewers

betoredhat commented Apr 16, 2025 •

edited by tonyskapunk

Loading

coderabbitai bot commented Apr 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)