Validate cephobjectstoreuser objects #716

betoredhat · 2025-06-25T00:47:58Z

SUMMARY

Add extra validation for nooba objects to be Ready

ISSUE TYPE

nominal change

Tests

TestBos2: virt-prega-4.20 - https://www.distributed-ci.io/jobs/c3fad45f-257e-4eaf-be50-c613716d26dd/jobStates

Test-Hint: no-check

coderabbitai · 2025-06-25T00:48:18Z

📝 Walkthrough

Walkthrough

A new task was added to the end of the OpenShift storage operator playbook to wait until all CephObjectStoreUser resources in the ocs_storage_namespace are in the "Ready" phase, using retries and status checks.

Changes

File(s)	Change Summary
roles/odf_setup/tasks/openshift-storage-operator.yml	Added a task to wait for all CephObjectStoreUser resources to reach the "Ready" phase with retries.

Possibly related PRs

Wait for StorageCluster to be ready #649: Adds similar readiness wait tasks for Ceph-related resources in the same playbook using comparable retry logic.

Suggested reviewers

manurodriguez
tonyskapunk

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31a2506 and 5f5afdb.

📒 Files selected for processing (1)

roles/odf_setup/tasks/openshift-storage-operator.yml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

roles/odf_setup/tasks/openshift-storage-operator.yml

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Ansible-lint Check
GitHub Check: Sanity Check (stable-2.9)
GitHub Check: Sanity Check (stable-2.18)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

softwarefactory-project-zuul · 2025-06-25T00:51:07Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/8448fca325ef4510bd89b25d56d1c46a

✔️ dci-rpm-build-el8 SUCCESS in 2m 52s
✔️ dci-rpm-build-el9 SUCCESS in 2m 19s

coderabbitai

Actionable comments posted: 3

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 33fb704 and b9cb190.

📒 Files selected for processing (1)

roles/odf_setup/tasks/openshift-storage-operator.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Sanity Check (stable-2.18)
GitHub Check: Ansible-lint Check
GitHub Check: Sanity Check (stable-2.9)

roles/odf_setup/tasks/openshift-storage-operator.yml

softwarefactory-project-zuul · 2025-06-25T01:03:18Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/6de4cbf70cca42778f06dcebfd0b4e5f

✔️ dci-rpm-build-el8 SUCCESS in 2m 55s
✔️ dci-rpm-build-el9 SUCCESS in 2m 19s

softwarefactory-project-zuul · 2025-06-25T01:06:26Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/542aa500fb9546b8988a55ed8a2499a0

✔️ dci-rpm-build-el8 SUCCESS in 2m 53s
✔️ dci-rpm-build-el9 SUCCESS in 2m 20s

dcibot · 2025-06-25T02:31:28Z

from change #716:

FAILURE https://www.distributed-ci.io/jobs/402b2150-7df8-4049-abe2-aa2d40436d9b/jobStates

betoredhat · 2025-06-25T02:39:48Z

recheck

softwarefactory-project-zuul · 2025-06-25T02:42:51Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/f9d09736ee764142bcd67125063aed22

✔️ dci-rpm-build-el8 SUCCESS in 2m 50s
✔️ dci-rpm-build-el9 SUCCESS in 2m 20s

dcibot · 2025-06-25T05:45:04Z

from change #716:

SUCCESS https://www.distributed-ci.io/jobs/c3fad45f-257e-4eaf-be50-c613716d26dd/jobStates

manurodriguez

LGTM

betoredhat · 2025-06-25T18:57:07Z

recheck

dcibot · 2025-06-25T18:57:11Z

from change #716:

no check (not a code change)

dcibot · 2025-06-25T18:57:11Z

from change #716:

no check (not a code change)

softwarefactory-project-zuul · 2025-06-25T19:00:14Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/d76aa885dff54761950ac96b9e6cf68f

✔️ dci-rpm-build-el8 SUCCESS in 2m 49s
✔️ dci-rpm-build-el9 SUCCESS in 2m 26s

betoredhat requested a review from a team as a code owner June 25, 2025 00:47

coderabbitai bot reviewed Jun 25, 2025

View reviewed changes

roles/odf_setup/tasks/openshift-storage-operator.yml Outdated Show resolved Hide resolved

roles/odf_setup/tasks/openshift-storage-operator.yml Outdated Show resolved Hide resolved

roles/odf_setup/tasks/openshift-storage-operator.yml Outdated Show resolved Hide resolved

betoredhat force-pushed the check_cosu branch from b9cb190 to 31a2506 Compare June 25, 2025 00:58

Validate cephobjectstoreuser objects

5f5afdb

betoredhat force-pushed the check_cosu branch from 31a2506 to 5f5afdb Compare June 25, 2025 01:01

manurodriguez approved these changes Jun 25, 2025

View reviewed changes

betoredhat added this pull request to the merge queue Jun 25, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 25, 2025

betoredhat added this pull request to the merge queue Jun 25, 2025

betoredhat removed this pull request from the merge queue due to a manual request Jun 25, 2025

betoredhat added this pull request to the merge queue Jun 25, 2025

Merged via the queue into main with commit a8caf3b Jun 25, 2025
8 checks passed

betoredhat deleted the check_cosu branch June 25, 2025 19:11

coderabbitai bot mentioned this pull request Jun 26, 2025

[odf_setuo] Reduce retries for cephobjectstoreusers #719

Merged

1 task

coderabbitai bot mentioned this pull request Aug 4, 2025

[odf_setup] increase retries for StorageCluster resource to be ready #761

Merged

1 task

Validate cephobjectstoreuser objects #716

Validate cephobjectstoreuser objects #716

Uh oh!

Conversation

betoredhat commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

ISSUE TYPE

Tests

Uh oh!

coderabbitai bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

softwarefactory-project-zuul bot commented Jun 25, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Jun 25, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 25, 2025

Uh oh!

dcibot commented Jun 25, 2025

Uh oh!

betoredhat commented Jun 25, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 25, 2025

Uh oh!

dcibot commented Jun 25, 2025

Uh oh!

manurodriguez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

betoredhat commented Jun 25, 2025

Uh oh!

dcibot commented Jun 25, 2025

Uh oh!

dcibot commented Jun 25, 2025

Uh oh!

softwarefactory-project-zuul bot commented Jun 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

betoredhat commented Jun 25, 2025 •

edited

Loading

coderabbitai bot commented Jun 25, 2025 •

edited

Loading