increase wait for ocs

[betoredhat]

SUMMARY

Seen this taking more time to consolidate

ISSUE TYPE

• nominal change

Tests

Test-Hint: no-check

[coderabbitai]

📝 Walkthrough

Walkthrough

In roles/odf_setup/tasks/openshift-storage-operator.yml, the retries count for the “Get OCS health status” task is increased from 60 to 90. The delay and until conditions are unchanged. No other modifications are made.

Changes

Cohort / File(s)	Summary of Changes
ODF setup tasks roles/odf_setup/tasks/openshift-storage-operator.yml	Increased retries for “Get OCS health status” from 60 to 90; delay and until conditions unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• Wait for StorageCluster to be ready #649 — Also adjusts OCS readiness wait behavior in the same playbook by adding an explicit wait for StorageCluster Ready.

Suggested reviewers

• manurodriguez
• tkrishtop

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch inc_wait

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "increase wait for ocs" accurately and succinctly reflects the primary change in the PR — increasing the wait/retries for the OCS health check — so it is relevant and easy to scan. It is concise and on-topic, though slightly informal and could be marginally more specific about the parameter changed.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Description Check	✅ Passed	The PR description states the operation is taking longer and labels the change as a nominal timing adjustment, which directly relates to the changeset that increases the OCS wait/retries; although brief, it is on-topic and consistent with the raw_summary. The description is therefore sufficient for this lenient check. No substantive mismatch between description and the single-file change was found.

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/ec821aa2384d4c97a9d6391b49fc98c9

✔️ dci-rpm-build-el8 SUCCESS in 2m 53s
✔️ dci-rpm-build-el9 SUCCESS in 2m 23s

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

roles/odf_setup/tasks/openshift-storage-operator.yml (3)

43-45: 90 retries ⇒ 30-minute max wait; confirm CI/operator timeouts and consider making it tunable.

At delay 20s, this raises worst-case wait to ~30m. Verify this won’t trip CI job limits or operator-level timeouts. Suggest parameterizing to avoid future code churn.

-  retries: 90
-  delay: 20
+  retries: "{{ ocs_health_retries | default(90) }}"
+  delay: "{{ ocs_health_delay | default(20) }}"

---

46-48: Simplify the state check for readability (and avoid quoting the whole expression).

Current form is hard to parse. This is equivalent and clearer.

-    - ("'Connected' in ocs_health_status.resources[0].status.state") or ("'Ready' in ocs_health_status.resources[0].status.state")
+    - ocs_health_status.resources[0].status.state in ['Connected', 'Ready']

---

84-85: Task name says “20 mins” but logic waits up to ~25 mins.

Either update the label or adjust retries/delay to truly cap at 20 minutes.

Example label tweak:

• name: Wait up to ~25 mins Storage Cluster to be ready

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc36b0d and 3ef8a4e.

📒 Files selected for processing (1)

• roles/odf_setup/tasks/openshift-storage-operator.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Ansible-lint Check
• GitHub Check: Sanity Check (stable-2.9)
• GitHub Check: Sanity Check (stable-2.18)

[dcibot]

from change #780:

• RUNNING https://www.distributed-ci.io/jobs/df6d284d-42e6-4202-8cef-257c12965eb5/jobStates

[rajchiluveru]

Looks good to me.

[betoredhat]

recheck

[dcibot]

from change #780:

• no check (not a code change)

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/b4221927034845098cd0d846bd62654c

✔️ dci-rpm-build-el8 SUCCESS in 2m 53s
✔️ dci-rpm-build-el9 SUCCESS in 2m 22s