Skip to content

Add RxUI snippets for Visual Studio and VS for Mac #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonstodle wants to merge 446 commits into from
Closed

Add RxUI snippets for Visual Studio and VS for Mac #1438

jonstodle wants to merge 446 commits into from

Conversation

@jonstodle
Copy link
Contributor

@jonstodle jonstodle commented Aug 26, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature, kind of

What is the current behavior? (You can also link to an open issue here)
Relates to: "official" visual studio/resharper code snippets #1051

What is the new behavior (if this is a feature change)?
Snippets for adding this.Bind, this.OneWayBind, this.BindCommand and a get/set RxUI property

What might this PR break?
I believe nothing

Please check if the PR fulfills these requirements

Other information:

ghuntley and others added 30 commits April 1, 2016 22:32
@ghuntley
all packages building for all platforms (except Xamarin.Mac) and publ…
9962407 
…ishing to myget
@ghuntley
these aren't needed anymore
abc7da8
@ghuntley
Delete .keepme
3cd034e
@ghuntley
Delete .keepme
66b96ee
@ghuntley
these are not needed anymore
6cab902
@mteper
Placeholder NuGet.Config for @ghuntley to plug his MyGet feed URL into
42f2d64
@aalmada
Merge branch 'rxui7-master' of https://github.com/aalmada/ReactiveUI …
27b6084 
…into rxui7-master
@ghuntley
added pre-release nuget feed details
da38bce
@aalmada
Merge remote-tracking branch 'refs/remotes/reactiveui/rxui7-master' i…
54e5b2c 
…nto rxui7-master
@aalmada
Added .AsObservable() when ISubject is returned as IObservable
e4c111b 
Prevents consumer from casting the result back to an ISubject:
http://www.introtorx.com/content/v1.0.10621.0/09_SideEffects.html#AsObservable
I don't have Cocoa development environment so I didn't test for this
platform.
@moswald
Merge pull request #1095 from aalmada/AsObservable
4d8e5ce 
Added .AsObservable() when ISubject is returned as IObservable
Remove Xam Forms from Events / PCL
95b8a9f 
Xam Forms should not be automatically pulled into any PCL that uses events.
@ghuntley
reactiveui-xamforms now targets "portable-net45+netcore45+wp8+UAP10+M…
a0ce9e0 
…onoAndroid403+MonoTouch10+Xamarin.iOS10"
@ghuntley
created 'reactiveui-events-xamforms' nuget package
f900bb9 
fixes #1098
@ghuntley
min target is now MonoAndroid403 aka Android 4.0.3 / API Level 15
8f276b7
@ghuntley
publish reactiveui-events-xamforms package
74f3fa0
@ghuntley
use v2.1.0.6529 of Xamarin.Forms
51702a4
@ghuntley
updated reactiveui-events-xamforms description
63fbf76
@ghuntley
min target is now MonoAndroid403 aka Android 4.0.3 / API Level 15
27a216c
@ghuntley
target portable-net45+netcore45+wp8+UAP10+MonoAndroid403+MonoTouch10+…
010eb7c 
…Xamarin.iOS10
@ghuntley
publish reactiveui-testing to myget
c55054f
@ghuntley
min target is now MonoAndroid403 aka Android 4.0.3 / API Level 15
245d5cb
@ghuntley
build .net45 unit tests
41ba198
@flagbug
Merge pull request #1061 from reactiveui/oaph-defer-subscription
820c317 
Subscribe to the source of an ObservableAsPropertyHelper immediately and add a deferSubscription parameter
@flagbug
Fix the XML docs stating that the default scheduler is the UI scheduler
0f3a0c2 
Fixes #1075
@PureWeen
changed LaunchActivatedEventArgs to IActivatedEventArgs to make it wo…
4f673a5 
…rk with resume behavior. Renamed variable from _launched to _Activated
@flagbug
Merge pull request #1099 from PureWeen/IActivatedEventArgs_insteadof_…
545e2d0 
…LaunchActivatedEventArgs_rxui7

changed LaunchActivatedEventArgs to IActivatedEventArgs
@ghuntley
Merge branch 'rxui7-master' of github.com:reactiveui/ReactiveUI into …
6eb147b 
…myget
@ghuntley
added .net45 test runner but disabled for now
7ec75f1
@ghuntley
>= 7.0.0 will do. No need to lock to == [7.0.0]
8ae2100
ghuntley and others added 17 commits August 6, 2017 14:34
@ghuntley
housekeeping: nuget packaging 💄 (#1414)
e986785
@kentcb @ghuntley
housekeeping: improve wording on PR template (#1415)
f8ef402
@ghuntley
chore: use pre-release visual studio 2017 sdk to work around tooling …
91433b1 
…issues (#1416)
@olevett
chore: update to xunit 2 (#1380)
e8b6c0b 
Fixes #1301
@ghuntley
housekeeping: use .NET foundation appveyor infrastructure (#1419)
f33b96c
@kentcb @ghuntley
chore: cull Splat methods that were never removed (#1423)
5d61482
@olevett @ghuntley
housekeeping: resolve red builds on the develop branch after VS2017 1…
d9a066f 
…5.3 (#1428)

Fixes #1420 
Fixes #1409
@ghuntley
housekeeping: added identity signing to NuGet packages (#1426)
e1d5fb6
@ghuntley
housekeeping: ignore cla github labels otherwise release will break (#…
72b4921 
…1430)
@kentcb
fix: roll back ReactiveUI.Wpf project to standard csproj
dea8a4b
@kentcb @ghuntley
fix: removed duplicate ComponentModelTypeConverter for WPF (#1433)
e5187bd
@olevett @ghuntley
housekeeping update ISSUE_TEMPLATE to match website (#1432)
72531f1
@ghuntley
feature: automatically close stale github issues in a friendly way (#…
c2981d6 
…1435)
@ghuntley
housekeeping: merged probot message into single line (#1436)
e8227e8
@jkoritzinsky @olevett
feature: add netcoreapp build (#1418)
c1285aa
@jonstodle
4db09ee 
Add Visual Studio snippets
@jonstodle
a48cfac 
Add Visual Studio for Mac snippets
@dnfclas
Copy link

dnfclas commented Aug 26, 2017

@jonstodle,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@jonstodle
Copy link
Contributor Author

jonstodle commented Aug 26, 2017

@ghuntley Not sure I'm doing this right, so if there's anything to point out, don't be shy.

@coveralls
Copy link

coveralls commented Aug 26, 2017

Coverage Status

Changes Unknown when pulling a48cfac on jonstodle:jonstodle/snippets into ** on reactiveui:snippets**.

@jonstodle
ddb1be8 
Remove unessecary elements
@coveralls
Copy link

coveralls commented Aug 26, 2017

Coverage Status

Changes Unknown when pulling ddb1be8 on jonstodle:jonstodle/snippets into ** on reactiveui:snippets**.

@dnfclas
Copy link

dnfclas commented Aug 26, 2017

@jonstodle, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

@ghuntley
Copy link
Member

ghuntley commented Aug 29, 2017

Not sure what happened here @jonstodle but this PR is all janky. There should only be one or two commits (the snippets). Can you please close this PR, clone down reactiveui:develop, create a new branch, do the needed, open a PR? Ta

@ghuntley ghuntley closed this Aug 29, 2017
@jonstodle
Copy link
Contributor Author

jonstodle commented Aug 29, 2017

Yeah, I'm sorry about this. I've made a new PR: #1444

@lock lock bot locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.