Skip to content

Conversation

@kentcb
Copy link
Contributor

@kentcb kentcb commented Aug 24, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

fix

What is the current behavior? (You can also link to an open issue here)

The ReactiveUI.Wpf project includes ComponentModelTypeConverter even though it's already in ReactiveUI.

What is the new behavior (if this is a feature change)?

Remove ComponentModelTypeConverter from ReactiveUI.WPF. Also, fix comments in the copy inside ReactiveUI because it actually has nothing to do with WPF.

What might this PR break?

Nothing realistic.

Please check if the PR fulfills these requirements

Other information:

@dnfclas
Copy link

dnfclas commented Aug 24, 2017

@kentcb,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 88a668b on kentcb:component-model-type-converter into ** on reactiveui:develop**.

@ghuntley ghuntley merged commit e5187bd into reactiveui:develop Aug 25, 2017
@ghuntley ghuntley added this to the 8.0.0 milestone Aug 25, 2017
@lock lock bot locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants