Skip to content

Conversation

@kentcb
Copy link
Contributor

@kentcb kentcb commented Aug 14, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

chore

What is the current behavior? (You can also link to an open issue here)

Registration methods were duplicated in ReactiveUI and Splat.

What is the new behavior (if this is a feature change)?

Remove the duplicate methods from ReactiveUI.

What might this PR break?

People who explicitly used the RxUI methods. They should just use the Splat ones instead.

Please check if the PR fulfills these requirements

Other information:

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 66.75% when pulling 684984b on kentcb:cull-duplicate-ext-methods into f33b96c on reactiveui:develop.

@ghuntley
Copy link
Member

This is hangover from when Splat used to be inside of ReactiveUI:

https://reactivex.slack.com/archives/C02AJB872/p1502694681578307

@ghuntley ghuntley added this to the 8.0.0 milestone Aug 14, 2017
@ghuntley ghuntley merged commit 5d61482 into reactiveui:develop Aug 14, 2017
@ghuntley ghuntley removed the BREAKING label May 1, 2018
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants