feat(optimus): add namespace name to RegisterSecretRequest #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbchaos
force-pushed
the
optimus-secret-management
branch
2 times, most recently
from
27b7479 to
9788779
Compare
kushsharma
requested changes
Jan 4, 2022
sbchaos
force-pushed
the
optimus-secret-management
branch
2 times, most recently
from
422ffc7 to
efd2669
Compare
sbchaos
force-pushed
the
optimus-secret-management
branch
from
efd2669 to
ed15955
Compare
kushsharma
reviewed
Jan 19, 2022
Comment on lines
+587
to
+588
| bool success = 1; | ||
| string message = 2; |
Member
There was a problem hiding this comment.
How are we using these? I don't think we need a success flag here?
Contributor
There was a problem hiding this comment.
Sure, will remove success flag from the proto in next PR.
sbchaos
added a commit
that referenced
this pull request
Feb 14, 2022
* feat(optimus): add namespace name to RegisterSecretRequest (#83) * feat(optimus): add namespace name to RegisterSecretRequest * feat(optimus): add option for update_only in RegisterSecretRequest * feat(optimus): add updateSecret api Co-authored-by: Sandeep Bhardwaj <[email protected]> * feat(optimus): add listSecrets api, remove unused field from secrets responses Co-authored-by: Arinda Arif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.