feat(optimus): add listSecrets api, remove unused fields #93
Conversation
* feat(optimus): add namespace name to RegisterSecretRequest * feat(optimus): add option for update_only in RegisterSecretRequest * feat(optimus): add updateSecret api Co-authored-by: Sandeep Bhardwaj <[email protected]>
| } | ||
|
|
||
| message ListSecretsResponse { | ||
| message Secret { |
There was a problem hiding this comment.
Shouldn't we extract this message at root level so we don't need to create again for Get call? We can add a value field as well but return it empty for List call? What do you think?
There was a problem hiding this comment.
As of now we don't have a GET call, we can extract this message when we have the GET and add required fields.
There was a problem hiding this comment.
That will require us to refractor the code again to use a different proto message right? Why not have it designed like that from the start?
There was a problem hiding this comment.
We do not have any GET call planned to expose cleartext secrets over api.
There was a problem hiding this comment.
Yes, get on a secret isn't planned, and the expectation from read is to return the plaintext secret, so the message will change again. So, we can keep it under SecretList
No description provided.