Skip to content

feat(optimus): add namespace name to RegisterSecretRequest #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbchaos merged 3 commits into from
Jan 25, 2022
Merged

feat(optimus): add namespace name to RegisterSecretRequest #83

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31033fb
feat(optimus): add namespace name to RegisterSecretRequest
arinda-arif Dec 16, 2021
ed15955
feat(optimus): add option for update_only in RegisterSecretRequest
sbchaos Jan 4, 2022
b4669db
feat(optimus): add updateSecret api
sbchaos Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions odpf/optimus/core/v1beta1/runtime.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,15 @@ service RuntimeService {
body: "*"
};
}

// UpdateSecret updates secret at project level
rpc UpdateSecret(UpdateSecretRequest) returns (UpdateSecretResponse) {
option (google.api.http) = {
put: "/v1beta1/project/{project_name}/secret/{secret_name}"
body: "*"
};
}

// ListProjects returns list of registered projects and configurations
rpc ListProjects(ListProjectsRequest) returns (ListProjectsResponse) {
option (google.api.http) = {
Expand Down Expand Up @@ -559,13 +568,26 @@ message RegisterSecretRequest {
string project_name = 1;
string secret_name = 2;
string value = 3; // base64 encoded secret value
string namespace_name = 4;
}

message RegisterSecretResponse {
bool success = 1;
string message = 2;
}

message UpdateSecretRequest {
string project_name = 1;
string secret_name = 2;
string value = 3; // base64 encoded secret value
string namespace_name = 4;
}

message UpdateSecretResponse {
bool success = 1;
string message = 2;
Comment on lines +587 to +588
Copy link
Member

@kushsharma kushsharma Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we using these? I don't think we need a success flag here?

Copy link
Contributor

@sbchaos sbchaos Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will remove success flag from the proto in next PR.

}

message ListProjectsRequest {}

message ListProjectsResponse {
Expand Down