Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v2
- uses: bufbuild/[email protected]
with:
version: 0.41.0
version: 0.54.1
Copy link
Member Author

@rohilsurana rohilsurana Aug 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded to be able to use api version: v1 of buf.yaml

- uses: bufbuild/[email protected]
with:
against: 'https://github.com/$GITHUB_REPOSITORY.git#branch=main'
17 changes: 17 additions & 0 deletions buf.lock
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Generated by buf. DO NOT EDIT.
version: v1
deps:
- remote: buf.build
owner: googleapis
repository: googleapis
branch: main
commit: d1a849b8f8304950832335723096e954
digest: b1-zJkwX0YeOp1Wa0Jaj_RqMLa2-oEzePH6PJEK8aaMeI4=
create_time: 2021-08-26T15:07:19.652533Z
- remote: buf.build
owner: grpc-ecosystem
repository: grpc-gateway
branch: main
commit: d1922677830c448eb65ec590f3abc734
digest: b1-zmmsl0XlsSF4_BhZe7w9NMdImBCRtMSn68rmn9H1faQ=
create_time: 2021-08-17T02:45:07.151993Z
13 changes: 8 additions & 5 deletions buf.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
version: v1beta1
build:
roots:
- .
version: v1
name: buf.build/odpf/proton
deps:
- buf.build/googleapis/googleapis
- buf.build/grpc-ecosystem/grpc-gateway
breaking:
use:
- WIRE
- WIRE
except:
- RESERVED_MESSAGE_NO_DELETE
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openapiv2 from grpc-gateway had some changes that are not compatible with this rule. We can remove this rule going forward.

Basically they had reserved fields so they could use them later, and now they implemented those.

4 changes: 2 additions & 2 deletions odpf/guardian/guardian.proto
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
syntax = "proto3";
package odpf.guardian;

import "odpf/third_party/googleapis/google/api/annotations.proto";
import "odpf/third_party/grpc-gateway/protoc-gen-openapiv2/options/annotations.proto";
import "google/api/annotations.proto";
import "protoc-gen-openapiv2/options/annotations.proto";
import "google/protobuf/struct.proto";
import "google/protobuf/timestamp.proto";

Expand Down
5 changes: 0 additions & 5 deletions odpf/metadata/dataset.proto

This file was deleted.

4 changes: 2 additions & 2 deletions odpf/optimus/runtime_service.proto
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
syntax = "proto3";
package odpf.optimus;

import "odpf/third_party/googleapis/google/api/annotations.proto";
import "odpf/third_party/grpc-gateway/protoc-gen-openapiv2/options/annotations.proto";
import "google/api/annotations.proto";
import "protoc-gen-openapiv2/options/annotations.proto";
import "google/protobuf/timestamp.proto";
import "google/protobuf/struct.proto";
import "google/protobuf/duration.proto";
Expand Down
201 changes: 0 additions & 201 deletions odpf/third_party/googleapis/LICENSE

This file was deleted.

31 changes: 0 additions & 31 deletions odpf/third_party/googleapis/google/api/annotations.proto

This file was deleted.

Loading