refactor: use buf.yaml to get third-party dependencies #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohilsurana
commented
Aug 30, 2021
rohilsurana
changed the title
rohilsurana
force-pushed
the
use-buf-deps
branch
from
c76cbb4 to
ba0f316
Compare
rohilsurana
changed the title
rohilsurana
commented
Aug 31, 2021
| - uses: bufbuild/[email protected] | ||
| with: | ||
| version: 0.41.0 | ||
| version: 0.54.1 |
Member
Author
There was a problem hiding this comment.
Upgraded to be able to use api version: v1 of buf.yaml
rohilsurana
commented
Aug 31, 2021
| - WIRE | ||
| - WIRE | ||
| except: | ||
| - RESERVED_MESSAGE_NO_DELETE |
Member
Author
There was a problem hiding this comment.
openapiv2 from grpc-gateway had some changes that are not compatible with this rule. We can remove this rule going forward.
Basically they had reserved fields so they could use them later, and now they implemented those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29
Instead of vendoring the third-party protobuf definitions use buf to get them.