Add Doxygen build and fix all warnings#164
Add Doxygen build and fix all warnings#164rapids-bot[bot] merged 24 commits intorapidsai:branch-0.36from
Conversation
|
@charlesbluca @wence- I'd appreciate your review here sometime next week. Sorry that it is such a long PR, fortunately ~2.8k lines are just the |
charlesbluca
left a comment
There was a problem hiding this comment.
Thanks @pentschev! So far I've only looked into the files generating the documentation, will follow up on the added docstrings themselves - would it make sense to add codespell as a pre-commit check in this PR as well? There are a few typos that might be easier to review and correct by adding that check and running through the changed files.
This is a great idea, I didn't know |
| wheel.packages = ["ucxx"] | ||
|
|
||
| [tool.codespell] | ||
| ignore-words-list = "cancelation,inflight" |
There was a problem hiding this comment.
Reasoning:
- cancelation: codespell corrects it to the British English spelling "cancellation" (with two
ls), whereas we chose the American spelling "cancelation(with onel`) as it is the one used by UCX; - inflight: that's how we've been writing it and there are many instances of the word "inflight" online, although dictionaries seem to point "in-flight" as correct
codespelldidn't find all its instances automatically so for now I ignored it, but we can review it if the consensus is we should definitely switch to "in-flight".
Co-authored-by: Charles Blackmon-Luca <[email protected]>
Co-authored-by: Charles Blackmon-Luca <[email protected]>
|
Thanks again @charlesbluca , I've addressed the points you raised. 🙂 |
|
Thanks for the review @charlesbluca ! |
|
/merge |
The C++ code was documented for some time but Doxygen build process was not included. This change now introduces Doxygen builds and fixes all documentation warnings.