handle more RAPIDS version formats in update-version.sh, refactor dependencies.yaml#174
handle more RAPIDS version formats in update-version.sh, refactor dependencies.yaml#174rapids-bot[bot] merged 15 commits intorapidsai:branch-0.37from jameslamb:update-version
Conversation
|
It looks like some conflicts crept in here. Maybe these files need to be regenerated with |
|
Have resolved conflicts with PR ( #164 ) |
jakirkham
left a comment
There was a problem hiding this comment.
As we are moving to rapids-dask-dependency in this PR, think we should update the Conda recipes as well. In particular am noticing these lines here
ucxx/conda/recipes/ucxx/meta.yaml
Lines 274 to 275 in 2249bed
@jakirkham I just did that in 20a86a4 I don't see any other uses of |
|
whoops that needs to be a RAPIDS version not UCX's version Will fix that momentarily. |
Co-authored-by: jakirkham <[email protected]>
|
I noticed a small issue, |
Totally fine, thanks for that! I hadn't noticed it. |
|
Thanks Bradley! 🙏 Had missed that |
Co-authored-by: jakirkham <[email protected]>
|
/merge |
|
Thanks all! 🙏 |
Contributes to rapidsai/build-planning#13.
Updates
update-version.shto correctly handle RAPIDS dependencies likecudf-cu12==24.2.*.This also pulls in some dependency refactoring originally added in #161, which allows greater use of dependencies.yaml globs (and therefore less maintenance effort to support new CUDA versions).
How I tested this
The portability of this updated
sedcommand was tested here: rapidsai/cudf#14825 (comment).In this repo, I ran the following:
Confirmed that that first
git diffchanged all the things I expected, and that second one showed 0 changes.