-
Notifications
You must be signed in to change notification settings - Fork 50
Add Doxygen build and fix all warnings #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
1fbfce8
Add `Doxyfile` for C++ docs
pentschev 42ed497
Fix wrong arguments in C++ doxygen comments
pentschev e079f8a
Document C++ exceptions
pentschev 8eb28a5
Add doxygen to `.gitignore`
pentschev e6e7c28
Add doxygen pre-commit hooks, dependencies and CI build files
pentschev 416909c
Document `ucxx::Component`
pentschev afb70f7
Document class and type descriptions.
pentschev 558cdbb
Add docs builds to GH workflows
pentschev a3cfa40
Fix dependencies installed in build_docs
pentschev b3de6d1
Update docs version in release script
pentschev b8759ee
Enable PR dependency on build-docs
pentschev ae157d8
Add missing docs include to dependencies
pentschev 24aa536
Fix conda channels to build docs in CI
pentschev 712f9ff
Disable Doxygen generation of LaTeX output
pentschev 556f230
Set RAPIDS version for docs
pentschev 85cab2b
Upgrade to doxygen=1.10.0
pentschev 800f05e
Fix typo in `ucxx::WorkerProgressThread` docs
pentschev 3d25c77
Add codespell to pre-commit
pentschev 698cbbe
Fix typos found by codespell
pentschev 36db557
Update CI checks to doxygen 1.10.0
pentschev e4513e6
Fix typo
pentschev de708d3
Merge remote-tracking branch 'upstream/branch-0.36' into doxygen
pentschev f70b5c4
Generate XML output with Doxygen
pentschev fd98e74
Remove cudatoolkit from docs-build
pentschev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,20 @@ jobs: | |
| branch: ${{ inputs.branch }} | ||
| date: ${{ inputs.date }} | ||
| sha: ${{ inputs.sha }} | ||
| docs-build: | ||
| if: github.ref_type == 'branch' | ||
| needs: conda-cpp-build | ||
| secrets: inherit | ||
| uses: rapidsai/shared-workflows/.github/workflows/[email protected] | ||
| with: | ||
| arch: "amd64" | ||
| branch: ${{ inputs.branch }} | ||
| build_type: ${{ inputs.build_type || 'branch' }} | ||
| container_image: "rapidsai/ci-conda:latest" | ||
| date: ${{ inputs.date }} | ||
| node_type: "gpu-v100-latest-1" | ||
| run_script: "ci/build_docs.sh" | ||
| sha: ${{ inputs.sha }} | ||
| upload-conda: | ||
| needs: [conda-cpp-build] | ||
| secrets: inherit | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,7 @@ jobs: | |
| needs: | ||
| - checks | ||
| - conda-cpp-build | ||
| - docs-build | ||
| - conda-cpp-tests | ||
| - conda-python-tests | ||
| secrets: inherit | ||
|
|
@@ -29,6 +30,16 @@ jobs: | |
| uses: rapidsai/shared-workflows/.github/workflows/[email protected] | ||
| with: | ||
| build_type: pull-request | ||
| docs-build: | ||
| needs: conda-cpp-build | ||
| secrets: inherit | ||
| uses: rapidsai/shared-workflows/.github/workflows/[email protected] | ||
| with: | ||
| build_type: pull-request | ||
| node_type: "gpu-v100-latest-1" | ||
| arch: "amd64" | ||
| container_image: "rapidsai/ci-conda:latest" | ||
| run_script: "ci/build_docs.sh" | ||
| conda-cpp-tests: | ||
| needs: conda-cpp-build | ||
| secrets: inherit | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,3 +25,6 @@ wheels/ | |
| *.egg-info/ | ||
| _skbuild/ | ||
|
|
||
| ## Doxygen | ||
| cpp/doxygen/html | ||
| cpp/doxygen/xml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| #!/bin/bash | ||
| # Copyright (c) 2023, NVIDIA CORPORATION. | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| rapids-logger "Create test conda environment" | ||
| . /opt/conda/etc/profile.d/conda.sh | ||
|
|
||
| ENV_YAML_DIR="$(mktemp -d)" | ||
|
|
||
| rapids-dependency-file-generator \ | ||
| --output conda \ | ||
| --file_key docs \ | ||
| --matrix "cuda=${RAPIDS_CUDA_VERSION%.*};arch=$(arch);py=${RAPIDS_PY_VERSION}" | tee "${ENV_YAML_DIR}/env.yaml" | ||
|
|
||
| rapids-mamba-retry env create --force -f "${ENV_YAML_DIR}/env.yaml" -n docs | ||
| conda activate docs | ||
|
|
||
| rapids-print-env | ||
|
|
||
| rapids-logger "Downloading artifacts from previous jobs" | ||
| CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp) | ||
|
|
||
| rapids-mamba-retry install \ | ||
| --channel "${CPP_CHANNEL}" \ | ||
| libucxx | ||
|
|
||
| export RAPIDS_VERSION_NUMBER="24.02" | ||
| export RAPIDS_DOCS_DIR="$(mktemp -d)" | ||
|
|
||
| rapids-logger "Build CPP docs" | ||
| pushd cpp/doxygen | ||
| doxygen Doxyfile | ||
| mkdir -p "${RAPIDS_DOCS_DIR}/libucxx/html" | ||
| mv html/* "${RAPIDS_DOCS_DIR}/libucxx/html" | ||
| popd | ||
|
|
||
| rapids-upload-docs | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #!/bin/bash | ||
| # Copyright (c) 2022-2024, NVIDIA CORPORATION. | ||
| ############################### | ||
| # cuDF doxygen warnings check # | ||
pentschev marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ############################### | ||
|
|
||
| # skip if doxygen is not installed | ||
| if ! [ -x "$(command -v doxygen)" ]; then | ||
| echo -e "warning: doxygen is not installed" | ||
| exit 0 | ||
| fi | ||
|
|
||
| # Utility to return version as number for comparison | ||
| function version { echo "$@" | awk -F. '{ printf("%d%03d%03d%03d\n", $1,$2,$3,$4); }'; } | ||
|
|
||
| # doxygen supported version 1.9.1 | ||
| DOXYGEN_VERSION=`doxygen --version` | ||
| if [ ! $(version "$DOXYGEN_VERSION") -eq $(version "1.9.1") ] ; then | ||
| echo -e "warning: Unsupported doxygen version $DOXYGEN_VERSION" | ||
| echo -e "Expecting doxygen version 1.9.1" | ||
pentschev marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| exit 0 | ||
| fi | ||
|
|
||
| # Run doxygen, ignore missing tag files error | ||
| TAG_ERROR1="error: Tag file '.*.tag' does not exist or is not a file. Skipping it..." | ||
| TAG_ERROR2="error: cannot open tag file .*.tag for writing" | ||
| DOXYGEN_STDERR=`cd cpp/doxygen && { cat Doxyfile ; echo QUIET = YES; echo GENERATE_HTML = NO; } | doxygen - 2>&1 | sed "/\($TAG_ERROR1\|$TAG_ERROR2\)/d"` | ||
| RETVAL=$? | ||
|
|
||
| if [ "$RETVAL" != "0" ] || [ ! -z "$DOXYGEN_STDERR" ]; then | ||
| echo -e "$DOXYGEN_STDERR" | ||
| RETVAL=1 #because return value is not generated by doxygen 1.8.20 | ||
| fi | ||
|
|
||
| exit $RETVAL | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.