Conversation
|
Pull requests from external contributors require approval from a |
| GIT_SHALLOW ${shallow} | ||
| PATCH_COMMAND ${patch_command} | ||
| EXCLUDE_FROM_ALL ${exclude} | ||
| OPTIONS "FMT_INSTALL ${to_install}") |
There was a problem hiding this comment.
In addition to this option there's a FMT_SYSTEM_HEADERS option that treats them as system includes instead of user includes presumably to make things like clang-tidy happy. If we want that option I'm happy to add it here (as well as for spdlog which also has the option).
There was a problem hiding this comment.
I'm not sure what to say here. @vyasr @robertmaynard?
There was a problem hiding this comment.
Does anyone know what the behavior of spdlog is when using an internal version of fmt? If it is marking the headers as system I don't mind re-producing that approach.
This will only effect when we are building fmt from source, since installed versions of fmt will always be treated as system due to how IMPORT targets in CMake behave.
| GIT_SHALLOW ${shallow} | ||
| PATCH_COMMAND ${patch_command} | ||
| EXCLUDE_FROM_ALL ${exclude} | ||
| OPTIONS "FMT_INSTALL ${to_install}") |
There was a problem hiding this comment.
I'm not sure what to say here. @vyasr @robertmaynard?
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
This looks fine to me.
@kkraus14 To revisit, you plan to open a follow-up PR to update the rapids-cmake pinning of spdlog and fetch fmt as a dependency? rapidsai/rmm#1177 (comment)
After that, wheel builds should start passing for rapidsai/rmm#1177 as I understand?
I can merge once you confirm the plan.
|
/ok to test |
bdice
added
improvement
Yes, that's correct. Updating that pinning needs to be coordinated with the RMM pr. |
|
/merge |
3 participants
Description
Adds fmt 9.1.0 to rapids-cmake via
rapids_cpm_fmtbased on discussion in rapidsai/rmm#1177. Nothing should be usingrapids_cpm_fmtyet so we don't need to version align it with spdlog until spdlog is updated to1.11.0.Depends on #366
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))