Skip to content

Clean up and sort CPM packages.#366

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-23.04from
bdice:cleanup-cpm-packages
Feb 8, 2023
Merged

Clean up and sort CPM packages.#366
rapids-bot[bot] merged 1 commit intorapidsai:branch-23.04from
bdice:cleanup-cpm-packages

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Feb 8, 2023

Description

Ensure that all CPM packages are in sorted order and are defined consistently.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice requested a review from a team as a code owner February 8, 2023 18:23
@bdice bdice mentioned this pull request Feb 8, 2023
7 tasks
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 8, 2023
@bdice
Copy link
Contributor Author

bdice commented Feb 8, 2023

/merge

@rapids-bot rapids-bot bot merged commit e938c7c into rapidsai:branch-23.04 Feb 8, 2023
rapids-bot bot pushed a commit that referenced this pull request Feb 8, 2023
Adds fmt 9.1.0 to rapids-cmake via `rapids_cpm_fmt` based on discussion in rapidsai/rmm#1177. Nothing should be using `rapids_cpm_fmt` yet so we don't need to version align it with spdlog until spdlog is updated to `1.11.0`.

Depends on #366

Authors:
  - Keith Kraus (https://github.com/kkraus14)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants