Allow nvbench to use an exiting fmt when brought in via find_package#125
Allow nvbench to use an exiting fmt when brought in via find_package#125robertmaynard wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
robertmaynard
added
type: bug: functional
robertmaynard
force-pushed
the
use_existing_fmt
branch
from
4cd6b3c to
455107e
Compare
| @@ -1,6 +1,7 @@ | |||
| ################################################################################ | |||
| # fmtlib/fmt | |||
| rapids_cpm_find(fmt 9.1.0 | |||
There was a problem hiding this comment.
nvbench originally requested that feature in rapidsai/rapids-cmake#101
alliepiper
left a comment
alliepiper
left a comment
There was a problem hiding this comment.
LGTM, @robertmaynard feel free to merge after addressing @bdice's question.
Are you okay moving to rapids-cmake 23.06 to get this feature? It would mean moving your minimum CMake version to |
|
@robertmaynard Can we finalize this PR? |
There is still open questions around the update to using rapids_cpm_fmt requiring nvbench to move to a newer rapids-cmake version, which would bump the CMake minimum version. If we are all fine with dropping that request ( or doing the bump ) I am happy to merge this. |
|
I'd support making this update by bumping the CMake minimum. @allisonvacanti Do you have any reservations about that? If there are issues with that, let's merge as-is without using |
|
Closing as these changes are now part of #140 |
3 participants
No description provided.