Use vendored RAPIDS.cmake in example code.#824
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from Apr 16, 2025
Merged
Use vendored RAPIDS.cmake in example code.#824rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
Conversation
bdice
added
improvement
Contributor
Author
|
/merge |
Member
|
One of the C++ tests failed in a CUDA 12.8 job: Think this is unrelated to the changes here Restarted the failing CI job |
Member
|
Huzzah it worked 🎉 Thanks Bradley and Ben! 🙏 |
rapids-bot Bot
pushed a commit
that referenced
this pull request
May 12, 2025
…only modify update-version.sh (#875) While reviewing #805, I found an issue with this project's `update-version.sh`... it refers to a script `examples/cmake/thirdparty/fetch_rapids.cmake` which no long exists (removed in #824). This proposes the following: * removing that reference from `update-version.sh` * skipping most CI on PRs that only modify `update-version.sh` ## Notes for Reviewers `ci/release/update-version.sh` is standardized (same filepath, same usage) across almost all RAPIDS repos. I cannot think of a situation where a PR that only changes that file would need to have any CI re-run (other than linting, e.g. for `shellcheck`). If folks agree, I'll roll out a change like that more broadly across RAPIDS. Authors: - James Lamb (https://github.com/jameslamb) - Ben Frederickson (https://github.com/benfred) Approvers: - Ben Frederickson (https://github.com/benfred) - Corey J. Nolet (https://github.com/cjnolet) - Gil Forsyth (https://github.com/gforsyth) URL: #875
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes example CMake code to use the vendored RAPIDS.cmake introduced in #816.
xref: https://github.com/rapidsai/build-infra/issues/206