update.version.sh: remove broken reference, skip most CI on PRs that only modify update-version.sh#875
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from May 12, 2025
jameslamb:fix/update-version
Merged
update.version.sh: remove broken reference, skip most CI on PRs that only modify update-version.sh#875rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from jameslamb:fix/update-version
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from
jameslamb:fix/update-version
Conversation
…t only touch update-version.sh
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
Author
|
/ok to test 09d48c6 |
jameslamb
added
improvement
jameslamb
changed the title
jameslamb
changed the title
benfred
approved these changes
May 8, 2025
cjnolet
approved these changes
May 8, 2025
Member
Author
|
/merge |
gforsyth
approved these changes
May 12, 2025
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #805, I found an issue with this project's
update-version.sh... it refers to a scriptexamples/cmake/thirdparty/fetch_rapids.cmakewhich no long exists (removed in #824).This proposes the following:
update-version.shupdate-version.shNotes for Reviewers
ci/release/update-version.shis standardized (same filepath, same usage) across almost all RAPIDS repos. I cannot think of a situation where a PR that only changes that file would need to have any CI re-run (other than linting, e.g. forshellcheck).If folks agree, I'll roll out a change like that more broadly across RAPIDS.