Vendor RAPIDS.cmake#816
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.06from Apr 10, 2025
Merged
Conversation
bdice
added
non-breaking
bdice
force-pushed
the
vendor-RAPIDS.cmake
branch
from
a2729a7 to
54731c0
Compare
pentschev
reviewed
Apr 10, 2025
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
KyleFromNVIDIA
approved these changes
Apr 10, 2025
Contributor
Author
|
/merge |
narangvivek10
pushed a commit
to SearchScale/cuvs
that referenced
this pull request
Apr 11, 2025
This works around a problem where GitHub is rejecting requests to the `githubusercontent.com` CDN. We vendor the contents of `RAPIDS.cmake` from `rapidsai/rapids-cmake` to avoid a network call. xref: rapidsai/rapids-cmake#809 xref: https://github.com/rapidsai/build-infra/issues/206 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: rapidsai#816
rapids-bot Bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
Fixes example CMake code to use the vendored RAPIDS.cmake introduced in #816. xref: rapidsai/build-infra#206 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ben Frederickson (https://github.com/benfred) URL: #824
benfred
added a commit
to benfred/cuvs
that referenced
this pull request
Jun 6, 2025
In rapidsai#816 we started to vendor rapids_config.cmake - but this broke the symlinks that rust/java use to build. Fix the symlinks to point to the new location, and add a precommit hook to check that symlinks are valid to prevent this from happening in the future
raydouglass
pushed a commit
that referenced
this pull request
Jun 6, 2025
In #816 we started to vendor rapids_config.cmake - but this broke the symlinks that rust/java use to build. Fix the symlinks to point to the new location, and add a precommit hook to check that symlinks are valid to prevent this from happening in the future
bkarsin
pushed a commit
to bkarsin/cuvs
that referenced
this pull request
Jun 19, 2025
In rapidsai#816 we started to vendor rapids_config.cmake - but this broke the symlinks that rust/java use to build. Fix the symlinks to point to the new location, and add a precommit hook to check that symlinks are valid to prevent this from happening in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around a problem where GitHub is rejecting requests to the
githubusercontent.comCDN. We vendor the contents ofRAPIDS.cmakefromrapidsai/rapids-cmaketo avoid a network call.xref: rapidsai/rapids-cmake#809
xref: https://github.com/rapidsai/build-infra/issues/206