Replace custom cuda_pinned_resource with RMM's pinned_host_memory_resource#1466
Merged
rapids-bot[bot] merged 4 commits intorapidsai:mainfrom Oct 30, 2025
Merged
Conversation
This was referenced Oct 25, 2025
bdice
added
improvement
Contributor
|
/ok to test |
rapids-bot Bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Oct 27, 2025
Makes `pinned_host_memory_resource` derive from `device_memory_resource` by implementing the standard `do_allocate`, `do_deallocate`, and `do_is_equal` interface. This is one step contributing to #2090 and is a prerequisite for #1429 / #2105. Unblocks follow-up work: - rapidsai/cudf#20003 - rapidsai/cuvs#1466 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) - Vyas Ramasubramani (https://github.com/vyasr) URL: #2102
Contributor
Author
|
@achirkin It looks like the CI run you triggered is passing. However, this should not have passed until the RMM PR was merged (which just happened). Is this code not being tested in CI? |
Contributor
|
Oh. Yes, this is a part of benchmarks, which we don't run in CI atm. |
achirkin
approved these changes
Oct 27, 2025
Contributor
Author
|
@achirkin Can you help build benchmarks on this PR to manually validate it? I tried I gave up here: |
Contributor
|
I confirm the affected benchmark builds and runs. |
Contributor
|
/merge |
github-project-automation
Bot
moved this from In Progress
to Done
in Unstructured Data Processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes custom
cuda_pinned_resourceimplementation and usesrmm::mr::pinned_host_memory_resourcedirectly.Depends on rapidsai/rmm#2102.
Closes #754.