Skip to content

Replace custom cuda_pinned_resource with RMM's pinned_host_memory_resource #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 4 commits into from
Oct 30, 2025
Merged

Replace custom cuda_pinned_resource with RMM's pinned_host_memory_resource #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec9a423
Replace custom cuda_pinned_resource with RMM's pinned_host_memory_res…
bdice Oct 25, 2025
91c0121
Merge branch 'main' into refactor-pinned-resource
bdice Oct 27, 2025
c0722d0
Merge remote-tracking branch 'upstream/main' into refactor-pinned-res…
bdice Oct 29, 2025
cd5455c
Merge branch 'main' into refactor-pinned-resource
achirkin Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 0 additions & 88 deletions cpp/bench/ann/src/common/cuda_pinned_resource.hpp
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions cpp/bench/ann/src/cuvs/cuvs_cagra_wrapper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
#include "../../../../src/neighbors/detail/cagra/utils.hpp"
#include "../common/ann_types.hpp"
#include "../common/cuda_huge_page_resource.hpp"
#include "../common/cuda_pinned_resource.hpp"
#include "cuvs_ann_bench_utils.h"
#include <rmm/mr/pinned_host_memory_resource.hpp>

#include <cuvs/distance/distance.hpp>
#include <cuvs/neighbors/cagra.hpp>
Expand Down Expand Up @@ -142,7 +142,7 @@ class cuvs_cagra : public algo<T>, public algo_gpu {
private:
// handle_ must go first to make sure it dies last and all memory allocated in pool
configured_raft_resources handle_{};
raft::mr::cuda_pinned_resource mr_pinned_;
rmm::mr::pinned_host_memory_resource mr_pinned_;
raft::mr::cuda_huge_page_resource mr_huge_page_;
AllocatorType graph_mem_{AllocatorType::kDevice};
AllocatorType dataset_mem_{AllocatorType::kDevice};
Expand Down