Derive pinned_host_memory_resource from device_memory_resource#2102
Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom Oct 27, 2025
Merged
Conversation
bdice
added
non-breaking
Collaborator
Author
|
Marking as |
This was referenced Oct 24, 2025
Merged
davidwendt
approved these changes
Oct 27, 2025
vyasr
approved these changes
Oct 27, 2025
ttnghia
reviewed
Oct 27, 2025
| [[maybe_unused]] std::size_t alignment = rmm::RMM_DEFAULT_HOST_ALIGNMENT) | ||
| void* do_allocate(std::size_t bytes, [[maybe_unused]] cuda_stream_view stream) override | ||
| { | ||
| RMM_FUNC_RANGE(); |
Collaborator
Author
There was a problem hiding this comment.
These ranges are supposed to be handled by the parent class's [de]allocate[_sync] in places like this:
Collaborator
Author
|
/merge |
This was referenced Oct 27, 2025
rapids-bot Bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
Closes #1429. Follow-up to #2102. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Tom Augspurger (https://github.com/TomAugspurger) URL: #2105
rapids-bot Bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Oct 30, 2025
…ource (#1466) Removes custom `cuda_pinned_resource` implementation and uses `rmm::mr::pinned_host_memory_resource` directly. Depends on rapidsai/rmm#2102. Closes #754. Authors: - Bradley Dice (https://github.com/bdice) - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Artem M. Chirkin (https://github.com/achirkin) URL: #1466
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
pinned_host_memory_resourcederive fromdevice_memory_resourceby implementing the standarddo_allocate,do_deallocate, anddo_is_equalinterface.This is one step contributing to #2090 and is a prerequisite for #1429 / #2105.
Unblocks follow-up work: