Skip to content

Conversation

@galipremsagar
Copy link
Contributor

This PR is WIP.

@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 19, 2022
@galipremsagar galipremsagar self-assigned this May 19, 2022
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels May 19, 2022
@jakirkham
Copy link
Member

Thanks Prem! 🙏

We did this for Dask-CUDA in PR ( rapidsai/dask-cuda#893 ) if that helps 🙂

Comment on lines +11 to +15
cudf_versioned = (
"cudf "
f"{os.environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').lstrip('v')}"
f"{os.environ.get('VERSION_SUFFIX', '')}"
)
Copy link
Contributor

@bdice bdice May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Pinning this isn't very friendly to source installs, since it relies on CI environment variables. For example, I don't think you could install a cudf package from conda and install dask-cudf from source with this construction. Do we want to couple these packages' installation methods that closely?

@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This PR has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates.

@jakirkham
Copy link
Member

jakirkham commented Nov 16, 2022

FWIW this will probably need to change when we move to pyproject.toml. We did this recently in Dask-CUDA and it wasn't too difficult. Would take a look at this commit ( rapidsai/dask-cuda@72bbfa4 ) or PR ( rapidsai/dask-cuda#1035 ) generally as a guide

@vyasr
Copy link
Contributor

vyasr commented Nov 29, 2022

@galipremsagar we should discuss how best to proceed here, and in particular how best to synchronize this with the work on the dependency file generator. I see that there is some logic in this PR to filter out cupy-cuda from the setup.py dependency list. In the interest of having a single source of truth (the new dependencies.yaml file), I think we would be better served by declaring the right groups of dependencies for each file type determined entirely by dependencies.yaml (including any differences between e.g. conda's cupy and PyPI's cupy-cuda11x). We may still want to leverage functions like load_file_data, but not load_setup_py_data since the management of dependency differences between the two would be handled upstream. @bdice I see that you took a look at this PR as well already, what do you think?

@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

A lot has changed since this PR was originally opened. We now use rapids-dependency-file-generator for most dependency generation (meta.yaml remains outstanding), and all Python package metadata has been moved to pyproject.toml. My guess is that at this point even if we wanted to move forward with this type of metadata sharing it would require a new implementation, so I'm going to close this PR.

@vyasr vyasr closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants