-
Notifications
You must be signed in to change notification settings - Fork 1k
[WIP] Make use of load_setup_py_data to have less/no duplication of packages
#10901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Make use of load_setup_py_data to have less/no duplication of packages
#10901
Conversation
|
Thanks Prem! 🙏 We did this for Dask-CUDA in PR ( rapidsai/dask-cuda#893 ) if that helps 🙂 |
| cudf_versioned = ( | ||
| "cudf " | ||
| f"{os.environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').lstrip('v')}" | ||
| f"{os.environ.get('VERSION_SUFFIX', '')}" | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Pinning this isn't very friendly to source installs, since it relies on CI environment variables. For example, I don't think you could install a cudf package from conda and install dask-cudf from source with this construction. Do we want to couple these packages' installation methods that closely?
|
This PR has been labeled |
|
This PR has been labeled |
|
FWIW this will probably need to change when we move to |
|
@galipremsagar we should discuss how best to proceed here, and in particular how best to synchronize this with the work on the dependency file generator. I see that there is some logic in this PR to filter out cupy-cuda from the setup.py dependency list. In the interest of having a single source of truth (the new dependencies.yaml file), I think we would be better served by declaring the right groups of dependencies for each file type determined entirely by dependencies.yaml (including any differences between e.g. conda's |
|
A lot has changed since this PR was originally opened. We now use |
This PR is WIP.