Pull requirements.txt into Conda recipe
#893
Conversation
jakirkham
added
non-breaking
|
|
||
| gpuci_logger "Build conda pkg for libcudf" | ||
| gpuci_logger "Build conda pkg for dask-cuda" | ||
| gpuci_conda_retry build conda/recipes/dask-cuda --python=${PYTHON} |
There was a problem hiding this comment.
It's worth noting that it is important for us to start in the directory containing setup.py as is already being done. Using a different directory doesn't work.
There isn't a good way to start from other directories atm. Please see issue ( conda/conda-build#3754 ) for context.
|
The other thing worth noting is there is a Setuptools deprecation warning that comes up ( conda/conda-build#4428 ) |
|
Is this ready for review or is there more to be addressed @jakirkham ? |
|
Technically it works. That said, think it is worthwhile to read up on the linked issues (particular the last one). |
|
@jakirkham is your preference for conda/conda-build#4430 to get merged in (and incorporated into gpuCI containers) before merging this? |
|
Sorry for the slow reply. So we can do this. The issue with Setuptools is in part they are changing the API (easy to fix in Conda-Build), but they are also flagging the new API as provisional. So there may be issues we run into in the future. I'm ok with trying this out. We can always go back to what we were doing before if there are issues with Setuptools, but wanted to make sure others here are aware of that and ok with that. |
|
Sorry @jakirkham , overlooked this thread. Since setuptools' API is changing anyway, I think there's no harm in trying, even if provisional bits change in the future, it doesn't seems like it will be a major setback for us, but I trust your judgement in this context better than mine. 😄 |
|
@gpucibot merge |
4 participants
Leverages
load_setup_py_datato extract the requirements fromsetup.pyand add them to the Conda recipe.