Skip to content

[WIP] Make use of load_setup_py_data to have less/no duplication of packages #10901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
galipremsagar wants to merge 3 commits into from
Closed

[WIP] Make use of load_setup_py_data to have less/no duplication of packages #10901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9500893
use common packages
galipremsagar May 19, 2022
f896030
updates
galipremsagar May 19, 2022
7685153
fix
galipremsagar May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions conda/recipes/cudf/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
{% set py_version=environ.get('CONDA_PY', 36) %}
{% set cuda_version='.'.join(environ.get('CUDA', '11.5').split('.')[:2]) %}
{% set cuda_major=cuda_version.split('.')[0] %}
{% set setup_data = load_setup_py_data(setup_file='../../../python/cudf/setup.py', from_recipe_dir=True) %}

package:
name: cudf
Expand Down Expand Up @@ -39,24 +40,19 @@ requirements:
- rmm {{ minor_version }}
- cudatoolkit {{ cuda_version }}
run:
- protobuf
- python
- typing_extensions
- pandas >=1.0,<1.5.0dev0
- cupy >=9.5.0,<11.0.0a0
- numba >=0.54
- numpy
- {{ pin_compatible('pyarrow', max_pin='x.x.x') }} *cuda
- libcudf {{ version }}
- fastavro >=0.22.0
- {{ pin_compatible('rmm', max_pin='x.x') }}
- fsspec>=0.6.0
- {{ pin_compatible('cudatoolkit', max_pin='x', min_pin='x') }}
- nvtx >=0.2.1
- packaging
- cachetools
- ptxcompiler # [linux64] # CUDA enhanced compatibility. See https://github.com/rapidsai/ptxcompiler
- cuda-python >=11.5,<12.0
{% for r in setup_data.get("install_requires", []) %}
{% if r|first not in "cupy-cuda" %}
- {{ r }}
{% endif %}
{% endfor %}
test: # [linux64]
requires: # [linux64]
- cudatoolkit {{ cuda_version }}.* # [linux64]
Expand Down
9 changes: 6 additions & 3 deletions conda/recipes/dask-cudf/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
{% set py_version=environ.get('CONDA_PY', 36) %}
{% set cuda_version='.'.join(environ.get('CUDA', '11.5').split('.')[:2]) %}
{% set cuda_major=cuda_version.split('.')[0] %}
{% set setup_data = load_setup_py_data(setup_file='../../../python/dask_cudf/setup.py', from_recipe_dir=True) %}

package:
name: dask-cudf
Expand Down Expand Up @@ -32,9 +33,11 @@ requirements:
- cudatoolkit {{ cuda_version }}
run:
- python
- cudf {{ version }}
- dask>=2022.03.0
- distributed>=2022.03.0
{% for r in setup_data.get("install_requires", []) %}
{% if r|first not in "cupy-cuda" %}
- {{ r }}
{% endif %}
{% endfor %}
- {{ pin_compatible('cudatoolkit', max_pin='x', min_pin='x') }}

test: # [linux64]
Expand Down
2 changes: 1 addition & 1 deletion python/cudf/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"cachetools",
"cuda-python>=11.5,<12.0",
"fsspec>=0.6.0",
"numba>=0.53.1",
"numba>=0.54",
"numpy",
"nvtx>=0.2.1",
"packaging",
Expand Down
10 changes: 8 additions & 2 deletions python/dask_cudf/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,14 @@

import versioneer

cudf_versioned = (
"cudf "
f"{os.environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').lstrip('v')}"
f"{os.environ.get('VERSION_SUFFIX', '')}"
)
Comment on lines +11 to +15
Copy link
Contributor

@bdice bdice May 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Pinning this isn't very friendly to source installs, since it relies on CI environment variables. For example, I don't think you could install a cudf package from conda and install dask-cudf from source with this construction. Do we want to couple these packages' installation methods that closely?


install_requires = [
"cudf",
cudf_versioned,
"dask>=2022.03.0",
"distributed>=2022.03.0",
"fsspec>=0.6.0",
Expand All @@ -22,7 +28,7 @@
"numpy",
"pandas>=1.0,<1.5.0dev0",
"pytest",
"numba>=0.53.1",
"numba>=0.54",
"dask>=2021.09.1",
"distributed>=2021.09.1",
]
Expand Down