Merged
Conversation
…hore-polkadot-v1.10.0
…polkadot-v1.10.0' into chungquantin/chore-polkadot-v1.10.0
…polkadot-v1.11.0' into chungquantin/chore-polkadot-v1.11.0
…polkadot-v1.11.0' into chungquantin/chore-polkadot-v1.11.0
al3mart
reviewed
Aug 15, 2024
Member
al3mart
left a comment
There was a problem hiding this comment.
Wouldn't have pushed back on including Litep2p. But appreaciate the prio.
Just left a comment regarding that we could add the genesis configs in the runtime with the changes coming from #2714. More as a reminder than anything else, as this might want to be done once we have finish working on the chain of upgrades.
Though, it is something I believe we want to do anyway.
Base automatically changed from
chungquantin/chore-polkadot-v1.10.0
to
developer
August 15, 2024 15:03
peterwht
approved these changes
Aug 15, 2024
Collaborator
peterwht
left a comment
There was a problem hiding this comment.
Approving! Added some "nice-to-have" comments for the build.rs. You can postpone to later PRs if it's easier for git rebasing etc.
Collaborator
|
[sc-918] |
al3mart
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: ✅ Tested on my local
devnet,testnet=> Block production / finalization + submit extrinsic works well.References
pallet-contracts:v1.10.0andv1.11.0pallet-xcm:v1.10.0andv1.11.0Direct changes
slot_durationfromaura::collators::basic::ParamsTryRuntimesubcommand